release tools #156

pohly · 2019-01-24T15:54:51Z

This syncs the build rules with the other kubernetes-csi repos.

The repo was created with an HTML version of the build.make file from https://github.com/pohly/csi-build-rules/. Here's the raw file.

It's worth calling out explicitly that only the master branch is maintained.

The actual repository was not named like the prototype repo.

initial content

Copy-and-paste error from the time when the kubernetes-csi/csi-release-tools repo didn't have the code...

README.md: fix repo URL for initial setup

The goal is to enforce that changes get merged upstream first and only get into the local repo via a normal "git subtree merge".

"make test" used to abort after the first test failure. That was partly intentional: if the simple tests already fail (for example, because of a syntax error), then there is no point in continuing to test. However, it also makes it harder to find all errors in a CI system when the errors are unrelated (first error shows up, gets fixed, next error shows up, etc.). Now "make test" still aborts early, but "make -k test" is used in the CI and will run all individual tests because they are split up into different targets.

We don't want to allow local modifications in the subtree. Everything should go to the csi-release-tools repo first.

check subtree for changes

This may or may not work, depending on which packages have tests and whether they contain glog.

Individual repos may have to filter out certain packages from testing. For example, in csi-test the cmd/csi-sanity directory contains a special test that depends on additional parameters that set the CSI driver to test against.

After merging into external-attacher, the next Travis CI run did not push the "canary" image because the check for "canary" only covered the case where "-canary" is used as suffix (https://travis-ci.org/kubernetes-csi/external-attacher/builds/484095261).

The introduction for each individual test looked like an actual command: test-subtree ./release-tools/verify-subtree.sh release-tools Directory 'release-tools' contains non-upstream changes: ... It's better to make it look like a shell comment and increase its visibility with a longer prefix: ### test-subtree: ./release-tools/verify-subtree.sh release-tools ...

pohly · 2019-01-25T11:00:11Z

/hold
Need to update the PR with a fix for publishing "canary" once merged into master (kubernetes-csi/csi-release-tools#4) and also get the local release--tools changes upstream (kubernetes-csi/csi-release-tools#5).

build.make: fix pushing of "canary" image from master branch

test enhancements

pohly · 2019-01-25T18:09:10Z

/hold cancel

bswartz · 2019-02-06T14:28:27Z

/lgtm

k8s-ci-robot · 2019-02-06T14:28:35Z

@bswartz: changing LGTM is restricted to assignees, and only kubernetes-csi/csi-test repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…631f2' git-subtree-dir: release-tools git-subtree-mainline: d400bcc git-subtree-split: 33d58fd

This switches building over to the shared csi-sanity-tools, which makes it simpler to keep building in the different repos in sync. For example, this now bumps the Go version to 1.11.1. For this to work, some files must be moved around to match the expected layout.

pohly · 2019-02-11T20:04:42Z

Rebased because of the merge conflict with 4df3ede

pohly · 2019-02-12T20:59:33Z

The new check actually works as intended:

### test-vet:
go vet `go list ./... | grep -v vendor `
# github.com/kubernetes-csi/csi-test/mock/service
mock/service/controller.go:511: Entry.Infof format %s has arg requestBytes of wrong type int64
make: *** [test-vet] Error 2

I need to fix the code before enforcing this check.

pohly · 2019-02-13T11:10:38Z

PR #166 has to be merged first to get a clean test result.

lpabon · 2019-02-14T19:03:14Z

release-tools/README.md

+
+Cheat sheet:
+
+- `git subtree add --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master` - add release tools to a repo which does not have them yet (only once)


I have to be honest about this, I feel this is really overkill for this project and is quite different from a normal git release process.

I'm concerned that I am going to mess something up (that's my biggest concern)

lpabon · 2019-02-14T19:03:45Z

release-tools/RELEASE.md

@@ -0,0 +1,5 @@
+# Release Process
+
+No tagged releases are planned at this point. The intention is to keep


Should this have the explanation on how to use this, or is it the README.md that we should follow?

lpabon · 2019-02-14T19:04:59Z

release-tools/build.make

+		docker tag $*:latest $(IMAGE_NAME):$$tag; \
+		docker push $(IMAGE_NAME):$$tag; \
+	}; \
+	for tag in $(IMAGE_TAGS); do \


To me this is almost magic. I am concerned with the maintenance of these tools and scripts. I feel only the author can maintain it and that is concerning.

lpabon · 2019-02-14T19:25:02Z

After an offline discussion on #wg-csi @pohly and @msau42 will maintain this code.

lpabon · 2019-02-14T19:28:30Z

/lgtm
/approve

k8s-ci-robot · 2019-02-14T19:28:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpabon, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lpabon,pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

release tools

spiffxp and others added 15 commits January 16, 2019 10:47

Initial commit from kubernetes-template-project

0535c0d

Add files from github.com/pohly/csi-build-rules

b41cac3

Port over information from kubernetes/org

d23a16c

build.make: initial content

a113647

The repo was created with an HTML version of the build.make file from https://github.com/pohly/csi-build-rules/. Here's the raw file.

RELEASE.md: clarify release process

51e16be

It's worth calling out explicitly that only the master branch is maintained.

README.md: update repo name, add initial setup step

c876547

The actual repository was not named like the prototype repo.

Merge pull request kubernetes-csi#1 from pohly/master

b32dd01

initial content

README.md: fix repo URL for initial setup

f49080e

Copy-and-paste error from the time when the kubernetes-csi/csi-release-tools repo didn't have the code...

Merge pull request kubernetes-csi#2 from pohly/repo-fix

520a04a

README.md: fix repo URL for initial setup

verify-subtree.sh: ensure that there are no local commits

73db459

The goal is to enforce that changes get merged upstream first and only get into the local repo via a normal "git subtree merge".

test: verify that 'release-tools' subtree is clean

f28c6b6

We don't want to allow local modifications in the subtree. Everything should go to the csi-release-tools repo first.

Merge pull request kubernetes-csi#3 from pohly/verify-subtree

3041b8a

check subtree for changes

build.make: clarify usage of "make V=1"

154e33d

This may or may not work, depending on which packages have tests and whether they contain glog.

build.make: support suppressing checks

147892c

Individual repos may have to filter out certain packages from testing. For example, in csi-test the cmd/csi-sanity directory contains a special test that depends on additional parameters that set the CSI driver to test against.

k8s-ci-robot requested review from lpabon and saad-ali January 24, 2019 15:54

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2019

pohly force-pushed the release-tools branch from fff0ef2 to 0476b4c Compare January 25, 2019 10:43

pohly added 2 commits January 25, 2019 11:48

pohly mentioned this pull request Jan 25, 2019

test enhancements kubernetes-csi/csi-release-tools#5

Merged

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2019

k8s-ci-robot added 2 commits January 25, 2019 08:03

Merge pull request kubernetes-csi#4 from pohly/canary-fix

be8a440

build.make: fix pushing of "canary" image from master branch

Merge pull request kubernetes-csi#5 from pohly/test-enhancements

33d58fd

test enhancements

pohly force-pushed the release-tools branch from 75333e6 to b48d09a Compare January 25, 2019 18:02

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2019

pohly mentioned this pull request Feb 5, 2019

Use real volumes when testing no capabilities #162

Merged

pohly added 2 commits February 11, 2019 21:01

Add 'release-tools/' from commit '33d58fdc29b90120bf16e536042379251f8…

223c84a

…631f2' git-subtree-dir: release-tools git-subtree-mainline: d400bcc git-subtree-split: 33d58fd

release tools

028b102

This switches building over to the shared csi-sanity-tools, which makes it simpler to keep building in the different repos in sync. For example, this now bumps the Go version to 1.11.1. For this to work, some files must be moved around to match the expected layout.

pohly force-pushed the release-tools branch from b48d09a to 028b102 Compare February 11, 2019 20:03

pohly mentioned this pull request Feb 14, 2019

Add StartOnAddress function to listen on unix:// paths #165

Merged

lpabon reviewed Feb 14, 2019

View reviewed changes

k8s-ci-robot assigned lpabon Feb 14, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2019

k8s-ci-robot merged commit d6050bc into kubernetes-csi:master Feb 14, 2019

suneeth51 pushed a commit to suneeth51/csi-test that referenced this pull request Sep 11, 2019

Merge pull request kubernetes-csi#156 from pohly/release-tools

722def7

release tools

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release tools #156

release tools #156

pohly commented Jan 24, 2019

pohly commented Jan 25, 2019

pohly commented Jan 25, 2019

bswartz commented Feb 6, 2019

k8s-ci-robot commented Feb 6, 2019

pohly commented Feb 11, 2019

pohly commented Feb 12, 2019

pohly commented Feb 13, 2019

lpabon Feb 14, 2019

lpabon Feb 14, 2019

lpabon Feb 14, 2019

lpabon commented Feb 14, 2019

lpabon commented Feb 14, 2019

k8s-ci-robot commented Feb 14, 2019


		Cheat sheet:

		- `git subtree add --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master` - add release tools to a repo which does not have them yet (only once)

		@@ -0,0 +1,5 @@
		# Release Process

		No tagged releases are planned at this point. The intention is to keep

release tools #156

release tools #156

Conversation

pohly commented Jan 24, 2019

pohly commented Jan 25, 2019

pohly commented Jan 25, 2019

bswartz commented Feb 6, 2019

k8s-ci-robot commented Feb 6, 2019

pohly commented Feb 11, 2019

pohly commented Feb 12, 2019

pohly commented Feb 13, 2019

lpabon Feb 14, 2019

Choose a reason for hiding this comment

lpabon Feb 14, 2019

Choose a reason for hiding this comment

lpabon Feb 14, 2019

Choose a reason for hiding this comment

lpabon commented Feb 14, 2019

lpabon commented Feb 14, 2019

k8s-ci-robot commented Feb 14, 2019