Use real volumes when testing no capabilities #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bswartz, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@bswartz, would you mind fixing gofmt? Travis uses go version 1.10.3 and does not like your code. |
Negative tests that expect the plugin to return InvalidArgument because no capabilities were supplied must use a real volume, otherwise plugins might return NotFound instead.
bswartz
force-pushed
the
fix-nocaps-tests
branch
from
1b47897 to
df2aef9
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
suneeth51
pushed a commit
to suneeth51/csi-test
that referenced
this pull request
Sep 11, 2019
Use real volumes when testing no capabilities
stmcginnis
pushed a commit
to stmcginnis/csi-test
that referenced
this pull request
Oct 9, 2024
…ommand prow.sh: allow shell commands in CSI_PROW_SANITY_POD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative tests that expect the plugin to return InvalidArgument because
no capabilities were supplied must use a real volume, otherwise plugins
might return NotFound instead.
Fixes #148