Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kops documentation #38

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Fix kops documentation #38

merged 2 commits into from
Oct 9, 2019

Conversation

vvbogdanov87
Copy link
Contributor

apiVersion is missed in EncryptionConfiguration
The pod contains errors preventing it to start.

@k8s-ci-robot
Copy link
Contributor

Welcome @vvbogdanov87!

It looks like this is your first PR to kubernetes-sigs/aws-encryption-provider 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-encryption-provider has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @vvbogdanov87. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2019
micahhausler
micahhausler requested changes Sep 12, 2019
View reviewed changes
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment on each of the changes and why they're needed?

KOPS.md Outdated
name: aws-encryption-provider
namespace: kube-system
spec:
containers:
- image: <image-of-aws-provider>
name: aws-encryption-provider
imagePullPolicy: Always
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more like a preference, can you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

KOPS.md
- key: dedicated
operator: Equal
value: master
effect: NoSchedule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve not used kops for a while and never extensively, but doesn’t the master have a NoSchedule taint you need a toleration for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as the below. Tolerations are for k8s scheduler. When the kubelet starts the static pod, it ignores this.

KOPS.md
volumes:
- name: kmsplugin
hostPath:
path: /srv/kubernetes
type: DirectoryOrCreate
nodeSelector:
dedicated: master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be run on a master, why is this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kops doesn't label master instances as "dedicated: master". Having a wrong selector prevents kubelet to start the pod. In the current case, the selector is not needed at all since the pod is scheduled not by k8s scheduler, instead, it is scheduled directly by kubelet.
More about static pods: https://kubernetes.io/docs/tasks/configure-pod-container/static-pod/

@vvbogdanov87
Copy link
Contributor Author

According to k8s docs "There are no health checks for the containers in a static Pod"
But I see health check probes in the provider logs.

I0913 02:54:37.928370       1 main.go:74] Passed healthceck: version:"v1beta1" runtime_name:"AWSKMS"
I0913 02:54:47.928569       1 main.go:74] Passed healthceck: version:"v1beta1" runtime_name:"AWSKMS"

Probably k8s docs are outdated. Therefore livenessProbe wasn't removed from the static pod spec.
I haven't found information regarding how priorityClass affects static pods. But there is a PR to kops repo where priorityClassName is set for all critical pods.
kubernetes/kops#6897

micahhausler
micahhausler approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks a bunch!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2019
@micahhausler
Copy link
Member

Sorry about the test failure, we'll need to fix the vendor checking to ensure it doesn't fail for cases like this

@micahhausler micahhausler mentioned this pull request Oct 6, 2019
Merged
@micahhausler
Copy link
Member

@vvbogdanov87 can you please rebase?

@vvbogdanov87
Fix specs
b279a11
@vvbogdanov87
Fix kops docs
89e1097 
remove imagePullPolicy and tolerations
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@micahhausler
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2019
@micahhausler
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, vvbogdanov87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fa467e9 into kubernetes-sigs:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahhausler micahhausler micahhausler approved these changes

@sethpollack sethpollack Awaiting requested review from sethpollack

Assignees

@micahhausler micahhausler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvbogdanov87 @k8s-ci-robot @micahhausler