Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set priority for static pods #6897

Merged
merged 3 commits into from Jul 12, 2019
Merged

Set priority for static pods #6897

merged 3 commits into from Jul 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2019

Setting a high priority for kube-proxy is important in clusters that run with PodPriority enabled, otherwise it will get evicted from worker nodes whenever there are unschedulable pods. Also set priorities for the other static pods defined by kops, mainly for completeness.

This should be safe these days since the API always accepts PriorityClassName even if PodPriority isn't enabled.

Fixes #6615.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @vainu-arto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2019
@ghost
Copy link
Author

ghost commented May 9, 2019

CLA should be fixed...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 9, 2019
@granular-ryanbonham
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2019
vainu-arto added 3 commits May 9, 2019 16:03
@vainu-arto
Add helpers to set the built-in pod priorities
555d879
@vainu-arto
Set priority classes for static pods
4897452 
For the master pods (apiserver, controller manager, scheduler) this is
unlikely to ever matter (the masters aren't expected to run out of
resources and need to evict things) but evictions of kube-proxy from worker
nodes are easy to trigger in clusters with PodPriority enabled. Since these
are static pods the configuration is also somewhat difficult to change.
@vainu-arto
Give etcd pods system-cluster-critical priority
238fdaf 
Again unlikely to matter since master nodes aren't expected to run out of
capacity, done mostly for completeness (all pods should usually have a
priority defined if the cluster is running with PodPriority enabled).
@granular-ryanbonham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@ghost
Copy link
Author

ghost commented May 10, 2019

/assign kashifsaadat

@ghost
Copy link
Author

ghost commented May 15, 2019

/assign @mikesplain

@ghost
Copy link
Author

ghost commented May 28, 2019

/assign @justinsb

@mikesplain
Copy link
Contributor

This looks good! We actually ran into this recently as well so I'm going to open cherry picks into the 1.13 and 1.14 branches too.

Thanks so much for the patience and for the contribution @vainu-arto!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, vainu-arto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
This was referenced Jun 27, 2019
Merged
Merged
@ghost
Copy link
Author

ghost commented Jun 28, 2019

/retest

1 similar comment
@ghost
Copy link
Author

ghost commented Jun 28, 2019

/retest

k8s-ci-robot added a commit that referenced this pull request Jul 2, 2019
@k8s-ci-robot
Merge pull request #7192 from mikesplain/automated-cherry-pick-of-#68…
cf6b69c 
…97-origin-release-1.14

Automated cherry pick of #6897: Add helpers to set the built-in pod priorities
k8s-ci-robot added a commit that referenced this pull request Jul 2, 2019
@k8s-ci-robot
Merge pull request #7191 from mikesplain/automated-cherry-pick-of-#68…
4f0bbca 
…97-origin-release-1.13

Automated cherry pick of #6897: Add helpers to set the built-in pod priorities
@ghost
Copy link
Author

ghost commented Jul 3, 2019

/retest

2 similar comments
@ghost
Copy link
Author

ghost commented Jul 9, 2019

/retest

@ghost
Copy link
Author

ghost commented Jul 12, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit dd6b031 into kubernetes:master Jul 12, 2019
@rifelpet
Copy link
Member

@mikesplain thoughts on cherry-picking this to earlier branches?

tariq1890 pushed a commit to tariq1890/kops that referenced this pull request Jul 12, 2019
@k8s-ci-robot @tariq1890
Merge pull request kubernetes#6897 from vainu-arto/set-priority-for-s…
2ade2e1 
…tatic-pods

Set priority for static pods
@andy-v-h andy-v-h mentioned this pull request Jul 24, 2019
Closed
@vvbogdanov87 vvbogdanov87 mentioned this pull request Sep 13, 2019
Merged
@johngmyers johngmyers mentioned this pull request Jan 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@mikesplain mikesplain

@KashifSaadat KashifSaadat

@granular-ryanbonham granular-ryanbonham

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to specify priorityClassName in kops managed manifests
7 participants
@k8s-ci-robot @granular-ryanbonham @mikesplain @rifelpet @justinsb @KashifSaadat @vainu-arto