Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor everything into packages #1

Closed
wants to merge 16 commits into from
Closed

WIP: Refactor everything into packages #1

wants to merge 16 commits into from

Conversation

philips
Copy link

@philips philips commented Apr 2, 2017

No description provided.

Brandon Philips added 16 commits April 1, 2017 15:09
AWS is an acronym and should be all capitals or all lower case due to
the Go style guide.
Lets be consistent and always call it the alb-ingress-controller
This particular example isn't terribly useful. Remove it.
Remove all mentions of specific domain names so that things can be
easily customized from the README.
Cleanup the configuration into sections or required and optional. This
makes it easier for someone to get started.
@bigkraig bigkraig changed the base branch from refactor to master April 3, 2017 02:42
@philips philips closed this Apr 6, 2017
joshrosso added a commit that referenced this pull request Apr 9, 2017
Working on bringing up our lint score
bigkraig pushed a commit that referenced this pull request May 10, 2018
Merge from coreos/alb-ingress-controller
bigkraig pushed a commit that referenced this pull request Jun 21, 2018
bigkraig pushed a commit that referenced this pull request Oct 1, 2018
Enable tags to be specified in ELBV2 input

Closes #1

See merge request !7
bigkraig pushed a commit that referenced this pull request Oct 1, 2018
Working on bringing up our lint score
bigkraig pushed a commit that referenced this pull request Oct 1, 2018
Merge from coreos/alb-ingress-controller
bigkraig pushed a commit that referenced this pull request Oct 1, 2018
@M00nF1sh M00nF1sh mentioned this pull request Nov 16, 2018
k8s-ci-robot pushed a commit that referenced this pull request Jul 15, 2019
@M00nF1sh M00nF1sh mentioned this pull request Apr 9, 2020
5 tasks
thejasn pushed a commit to thejasn/aws-load-balancer-controller that referenced this pull request Apr 7, 2022
Added downstream owners file and vendored dependencies
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Aug 21, 2023
Merge in DEL/aws-load-balancer-controller-fork from DELIVERY-8202_pull_upstream to main

* commit '49805eac72ec533acdbc2580d6f57c68a9cad45c':
  update the default base image (kubernetes-sigs#3075)
  update recommended IAM policy template (kubernetes-sigs#3068)
  update to discovery.k8s.io/v1 (kubernetes-sigs#3072)
  validation ingress condition annotation in validation webhook (kubernetes-sigs#2735)
  Fix conciseLogger's incorrect call to variadic func (kubernetes-sigs#3066)
  Verify CRDs are up to date in merge check (kubernetes-sigs#3022)
  Refactor model builder test (kubernetes-sigs#3024)
alebedev87 pushed a commit to alebedev87/aws-load-balancer-controller that referenced this pull request Oct 26, 2023
Added downstream owners file and vendored dependencies
diversario added a commit to plaid/aws-load-balancer-controller that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant