Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crictl logs should share code from kubelet. #169

Closed
Random-Liu opened this issue Oct 30, 2017 · 8 comments · Fixed by #186
Closed

crictl logs should share code from kubelet. #169

Random-Liu opened this issue Oct 30, 2017 · 8 comments · Fixed by #186
Assignees
Labels

Comments

@Random-Liu
Copy link
Contributor

Currently, we copy all the code from kubelet.

We should make the code in kubelet to be a CRI log parsing library. And import the library in crictl.

@yanxuean
Copy link
Contributor

Do you mean cri-tools/cmd/crictl/logs.go?

@Random-Liu
Copy link
Contributor Author

@yanxuean
Copy link
Contributor

I will fix it late.

@yanxuean
Copy link
Contributor

yanxuean commented Nov 3, 2017

@Random-Liu help:)
The cri-tools depend on k8s.io/kubernetes/pkg/kubelet/kuberuntime.
The kuberuntime depend on these as below:

k8s.io/apiextensions-apiserver
k8s.io/apiserver
k8s.io/metrics

The problem is how do I get the version of k8s.io/apiextensions-apiserver corresponding to k8s.io/kubernetes?

I checked kubernetes/Godeps/Godeps.json, there is not answer.

@yanxuean
Copy link
Contributor

yanxuean commented Nov 6, 2017

/cc @Random-Liu
The problem is how do I get the version of k8s.io/apiextensions-apiserver corresponding to k8s.io/kubernetes?

@feiskyer
Copy link
Member

feiskyer commented Nov 6, 2017

@yanxuean @Random-Liu We need to make kubelet logs a lib first. Let's make the code in kubelet to be a CRI log parsing library.

@yanxuean
Copy link
Contributor

yanxuean commented Nov 6, 2017

Agree. Now we need import kuberuntime. It is too complex.

@yanxuean
Copy link
Contributor

yanxuean commented Nov 6, 2017

The logs is indepent function.

yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 7, 2017
yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 7, 2017
yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 7, 2017
yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 7, 2017
yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 7, 2017
yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 8, 2017
yanxuean added a commit to yanxuean/cri-tools that referenced this issue Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants