-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crictl logs should share code from kubelet. #169
Comments
Do you mean cri-tools/cmd/crictl/logs.go? |
Yeah, most of the code there is the same with https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kuberuntime/kuberuntime_logs.go |
I will fix it late. |
@Random-Liu help:)
The problem is how do I get the version of k8s.io/apiextensions-apiserver corresponding to k8s.io/kubernetes? I checked kubernetes/Godeps/Godeps.json, there is not answer. |
/cc @Random-Liu |
@yanxuean @Random-Liu We need to make kubelet logs a lib first. Let's make the code in kubelet to be a CRI log parsing library. |
Agree. Now we need import kuberuntime. It is too complex. |
The logs is indepent function. |
fix kubernetes-sigs#169 Signed-off-by: yanxuean <[email protected]>
fix kubernetes-sigs#169 Signed-off-by: yanxuean <[email protected]>
fix kubernetes-sigs#169 Signed-off-by: yanxuean <[email protected]>
fix kubernetes-sigs#169 Signed-off-by: yanxuean <[email protected]>
fix kubernetes-sigs#169 kubernetes-sigs#177 Signed-off-by: yanxuean <[email protected]>
fix kubernetes-sigs#169 kubernetes-sigs#177 Signed-off-by: yanxuean <[email protected]>
Currently, we copy all the code from kubelet.
We should make the code in kubelet to be a CRI log parsing library. And import the library in
crictl
.The text was updated successfully, but these errors were encountered: