Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share logs with kubelet #186

Merged
merged 2 commits into from
Nov 10, 2017
Merged

share logs with kubelet #186

merged 2 commits into from
Nov 10, 2017

Conversation

yanxuean
Copy link
Contributor

@yanxuean yanxuean commented Nov 7, 2017 •
edited
Loading

fix #169 #177
Signed-off-by: yanxuean [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 7, 2017
@yanxuean yanxuean force-pushed the logs branch 3 times, most recently from 0b69f88 to bc2fc47 Compare November 7, 2017 15:40
@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 7, 2017

@feiskyer @Random-Liu

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 7, 2017

ptal

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 7, 2017

/assign @feiskyer @Random-Liu

@yanxuean
Copy link
Contributor Author

yanxuean commented Nov 8, 2017

/assign @Random-Liu @feiskyer
PTAL

feiskyer
feiskyer reviewed Nov 10, 2017
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you split the vendor updates to a separate commit?

@yanxuean
Copy link
Contributor Author

@feiskyer
I can.
Can you tell me the reason?

@feiskyer
Copy link
Member

feiskyer commented Nov 10, 2017 •
edited
Loading

For better tracking and understanding the commits histroy.

@yanxuean
Copy link
Contributor Author

@feiskyer
OK. thanks :)

@feiskyer
Copy link
Member

@yanxuean Maybe I'm not clear. I mean two commits in this PR, one is vendor and the other is calling new methods.

@yanxuean
Copy link
Contributor Author

I misunderstand. I modify it.

@yanxuean
Copy link
Contributor Author

@feiskyer @Random-Liu PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2017
feiskyer
feiskyer approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@feiskyer feiskyer merged commit b42fc3f into kubernetes-sigs:master Nov 10, 2017
@yanxuean yanxuean deleted the logs branch November 10, 2017 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crictl logs should share code from kubelet.
4 participants
@yanxuean @feiskyer @Random-Liu @k8s-ci-robot