Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For wildcard domains external-dns is not creating a proxied CNAME record in Cloudflare DNS #1810

Closed
gokulkrishnank opened this issue Oct 7, 2020 · 12 comments · Fixed by #2786
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@gokulkrishnank
Copy link

What happened:
Created service of type external-name with following manifest to create a proxied CNAME dns record in cloudflare.

kind: Service
apiVersion: v1
metadata:
  name: web-demo
  namespace: demo
  annotations:
    external-dns.alpha.kubernetes.io/hostname: "*.web.demo.example.com"
    external-dns.alpha.kubernetes.io/cloudflare-proxied: "true"
spec:
  type: ExternalName
  externalName: origin.demo.example.com

Our external-dns deployment configuration is as follows:

spec:
  containers:
  - args:
    - --source=service
    - --source=ingress
    - --provider=cloudflare
    - --zone-id-filter=xxxxxxxxxxxxxxxx
    - --domain-filter=demo.example.com
    - --policy=sync
    - --registry=txt
    - --txt-prefix=demo
    - --txt-owner-id=demo 
    envFrom:
    - secretRef:
        name: cloudflare-api-token
    image: k8s.gcr.io/external-dns/external-dns:v0.7.2
    name: external-dns
  securityContext:
    fsGroup: 65534
  serviceAccount: external-dns

With this configuration, a DNS record in cloudflare is created but with proxied status set to "DNS only". I am able to change it manually, but expecting the external-dns to create it so.

This configuration works fine with a non-wildcard domain
eg. With domain abc.web.demo.example.com, external-dns creates a proxied CNAME record

What you expected to happen:
A CNAME dns record with proxied status "proxied" is created with a wildcard domain

How to reproduce it (as minimally and precisely as possible):
With a functional external-dns with cloudflare configuration, apply the above manifest (with annotation external-dns.alpha.kubernetes.io/hostname set to a wildcard domain as above).

Anything else we need to know?:

Environment:

  • External-DNS version (use external-dns --version): v0.7.2-dirty
  • DNS provider: cloudflare
  • Others:
@gokulkrishnank gokulkrishnank added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@szuecs
Copy link
Contributor

szuecs commented Jan 19, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2021
@siarhei-karanets-epam
Copy link

/remove-lifecycle

@fiskhest
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@siarhei-karanets-epam
Copy link

/reopen

@k8s-ci-robot
Copy link
Contributor

@siarhei-karanets-epam: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@renehernandez
Copy link
Contributor

I am interesting on working on this feature, since it would speed up some of our dynamic environments at work. I'll look into the Cloudflare code and what it takes to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
8 participants