-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for wildcard domains #1927
Comments
@szuecs |
@jgrumboe updated, thanks |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Came across this after wondering why the annotation on my AWS ingress wasn't working for my wildcard domain: "external-dns.alpha.kubernetes.io/hostname": "*.foo.com"
"external-dns.alpha.kubernetes.io/ingress-hostname-source": "annotation-only" Would be great to support this for cases where the ALB gets traffic from many/any domain(s). EDIT: Turns out the correct format is "external-dns.alpha.kubernetes.io/hostname": "\\*.foo.com"
"external-dns.alpha.kubernetes.io/ingress-hostname-source": "annotation-only" |
I'm trying this on cloudflare.
external-dns output this error and then forcefully terminate always. |
related: #1810
What would you like to be added:
I think we do not support wildcard domains, because ingress spec did not allow them in v1beta1 and IIRC also not in v1.
People are now working on ingress v2 (aka gateway resource), see also http://sigs.k8s.io/service-apis.
For CRDs we can easily add on our side wildcard and external-dns source CRD has no restriction to the string parameters so wildcard seems to be possible. In case of source CRD, all controllers would need to maintain the external-dns CRD on create/update/delete operations.
For example ALB: when status loadbalancer changes, the controller creating the ALB would also need to update external-dns source CRD, which is quite an overhead if the community have to do it for all controllers (e.g. sig-aws controller, kube-ingress-controller, google, istio, gloo, nginx, .... ).
I think it makes sense to support wildcard hosts like
*.example.org
, which would need to match[a-z0-9-]+[.].example[.]org
, so only one dot supported as in DNS.Why is this needed:
ingress v2 is in progress and there are other CRDs that might support wildcards or want to support wildcards
The text was updated successfully, but these errors were encountered: