Add gopass plugin to krew plugin index #208
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,32 @@ | ||||||
| apiVersion: krew.googlecontainertools.github.com/v1alpha2 | ||||||
| kind: Plugin | ||||||
| metadata: | ||||||
| name: gopass | ||||||
| spec: | ||||||
| version: "v0.0.4" | ||||||
| platforms: | ||||||
| - selector: | ||||||
| matchExpressions: | ||||||
| - {key: os, operator: In, values: [darwin, linux]} | ||||||
| uri: https://github.com/gopasspw/kubectl-gopass/archive/v0.0.4.zip | ||||||
| sha256: "8bae04664693153555af921fb19b896aaccf39f7dec200e430816ff3fa47e1eb" | ||||||
| files: | ||||||
| - from: "/kubectl-gopass-*/kubectl-gopass" | ||||||
| to: "." | ||||||
| bin: "./kubectl-gopass" | ||||||
| - selector: | ||||||
| matchLabels: | ||||||
| os: windows | ||||||
| uri: https://github.com/gopasspw/kubectl-gopass/archive/v0.0.4.zip | ||||||
| sha256: "8bae04664693153555af921fb19b896aaccf39f7dec200e430816ff3fa47e1eb" | ||||||
| files: | ||||||
| - from: "/kubectl-gopass-*/kubectl-gopass" | ||||||
| to: "kubectl-gopass.exe" | ||||||
| bin: "./kubectl-gopass.exe" | ||||||
| shortDescription: Imports secrets from gopass | ||||||
|
There was a problem hiding this comment.
Suggested change
Making it a capital
|
||||||
| homepage: https://github.com/gopasspw/kubectl-gopass | ||||||
| caveats: | | ||||||
| This plugin requires bash and gopass | ||||||
| description: | | ||||||
|
There was a problem hiding this comment. Most plugins also give some basic usage instructions and how to get help. There was a problem hiding this comment. I think it's ok if --help/-h works. There was a problem hiding this comment. I can copy / paste the usage output here, but not sure what you will gain. I think the usage is quite obvious for gopass users right? |
||||||
| This plugin allows applying and diffing secrets from gopass to kubernetes | ||||||
| and creating kubernetes secrets in gopass (https://www.gopass.pw/). | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script is in pure bash. I think it would also make sense to allow installation on Windows and mention bash as a pre-requisite (which you already do).
Note: for windows, the script should have a
.exeending.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, windows has bash support in newest windows 10 build. I've enabled it. Not sure about the ending though. I will probably revisit later on as gopass support for windows itself is an ongoing topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit puzzled now. The manifest has a windows section which also make the CI test fail. Was that intentional?
If you want to add support for windows later, that's fine with me. I was not aware that
gopassis not available for windows yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it shouldn't fail. I made another attempt to fix the build.