Add gopass plugin to krew plugin index #208

martinhoefling · 2019-08-18T20:41:52Z

PLUGIN DEVELOPERS: @martinhoefling, with some hints from @corneliusweig

Exposes

inserting secrets to gopass from a template
diffing and applying a single secret stored in gopass
recursive diffing and applying secrets

via gopass subcommand.

k8s-ci-robot · 2019-08-18T20:41:53Z

Welcome @martinhoefling!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

martinhoefling · 2019-08-18T20:57:32Z

/assign @juanvallejo

ahmetb · 2019-08-18T22:16:27Z

plugins/gopass.yaml

+  shortDescription: Imports secrets from gopass
+  homepage: https://github.com/gopasspw/kubectl-gopass
+  caveats: |
+    This plugin requires bash and gopass to be set up correctly


“Correctly” is redundant.

ahmetb · 2019-08-18T22:16:45Z

plugins/gopass.yaml

+  caveats: |
+    This plugin requires bash and gopass to be set up correctly
+  description: |
+    This plugin allows applying and diffing secrets from gopass to k8s


Kubernetes is better.

ahmetb · 2019-08-18T22:17:01Z

/assign

corneliusweig

Hi, thanks for submitting this to the krew index. This already looks quite good, I only have minor comments.

corneliusweig · 2019-08-19T14:12:01Z

plugins/gopass.yaml

+  platforms:
+    - selector:
+        matchExpressions:
+          - {key: os, operator: In, values: [darwin, linux]}


The script is in pure bash. I think it would also make sense to allow installation on Windows and mention bash as a pre-requisite (which you already do).

Note: for windows, the script should have a .exe ending.

Actually, windows has bash support in newest windows 10 build. I've enabled it. Not sure about the ending though. I will probably revisit later on as gopass support for windows itself is an ongoing topic.

I'm a bit puzzled now. The manifest has a windows section which also make the CI test fail. Was that intentional?

If you want to add support for windows later, that's fine with me. I was not aware that gopass is not available for windows yet.

No it shouldn't fail. I made another attempt to fix the build.

corneliusweig · 2019-08-19T14:13:08Z

plugins/gopass.yaml

+metadata:
+  name: gopass
+spec:
+  version: "v0.0.3"


There is a version mismatch between this manifest and what is reported by kubectl gopass version (see https://github.com/gopasspw/kubectl-gopass/blob/59315e46389540624cca8c6ecb45694ed1dc3e87/kubectl-gopass#L140). Have you considered to generate deployment artifacts with a script?

Fixed, I added a small helper to create the tags and extracted the version as variable in the script.

corneliusweig · 2019-08-19T14:15:21Z

plugins/gopass.yaml

+        - from: "/kubectl-gopass-*/kubectl-gopass"
+          to: "."
+      bin: "./kubectl-gopass"
+  shortDescription: Imports secrets from gopass


Suggested change

shortDescription: Imports secrets from gopass

shortDescription: Imports Secrets from gopass

Making it a capital S signals that this is about kubernetes Secret resources. Or maybe even

Imports Secret resources from gopass

corneliusweig · 2019-08-19T14:19:10Z

plugins/gopass.yaml

+  homepage: https://github.com/gopasspw/kubectl-gopass
+  caveats: |
+    This plugin requires bash and gopass to be set up correctly
+  description: |


Most plugins also give some basic usage instructions and how to get help.

I think it's ok if --help/-h works.

I can copy / paste the usage output here, but not sure what you will gain. I think the usage is quite obvious for gopass users right?

Signed-off-by: Martin Hoefling <[email protected]>

ahmetb · 2019-08-20T23:43:53Z

Current manifest fails for Windows:

failed to install plugin "gopass": can't create symbolic link, source binary ("/tmp/krew-test665291632/store/gopass/8bae04664693153555af921fb19b896aaccf39f7dec200e430816ff3fa47e1eb/kubectl-gopass.exe") cannot be found in extracted archive: stat /tmp/krew-test665291632/store/gopass/8bae04664693153555af921fb19b896aaccf39f7dec200e430816ff3fa47e1eb/kubectl-gopass.exe: no such file or directory

corneliusweig

One final thought: do you wish to include a link to gopass, or is that tool so standard nowadays that it's simply not necessary?

corneliusweig · 2019-08-26T11:25:27Z

/approve
@ahmetb Do you want to take another look, or should I merge?

k8s-ci-robot · 2019-08-26T11:25:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig, martinhoefling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ahmetb · 2019-08-26T14:32:50Z

/lgtm

Add gopass plugin to krew plugin index

52bddd4

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2019

k8s-ci-robot requested review from corneliusweig and juanvallejo August 18, 2019 20:41

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 18, 2019

k8s-ci-robot assigned juanvallejo Aug 18, 2019

Fix typo in plugin

13bc453

ahmetb reviewed Aug 18, 2019

View reviewed changes

k8s-ci-robot assigned ahmetb Aug 18, 2019

corneliusweig suggested changes Aug 19, 2019

View reviewed changes

Update manifest and point to new version with suggested fixes

03cbfac

Signed-off-by: Martin Hoefling <[email protected]>

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 20, 2019

Set .exe as target in manifest for windows

7bf90c0

corneliusweig approved these changes Aug 22, 2019

View reviewed changes

Add gopass url to manifest description

4fe56f2

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2019

k8s-ci-robot merged commit 6c3575e into kubernetes-sigs:master Aug 26, 2019

ahmetb mentioned this pull request Aug 26, 2019

Question on bin files without .exe suffix kubernetes-sigs/krew#131

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add gopass plugin to krew plugin index #208

Add gopass plugin to krew plugin index #208

martinhoefling commented Aug 18, 2019

k8s-ci-robot commented Aug 18, 2019

martinhoefling commented Aug 18, 2019

ahmetb Aug 18, 2019

ahmetb Aug 18, 2019

ahmetb commented Aug 18, 2019

corneliusweig left a comment

corneliusweig Aug 19, 2019 •

edited

Loading

martinhoefling Aug 20, 2019

corneliusweig Aug 20, 2019 •

edited

Loading

martinhoefling Aug 22, 2019

corneliusweig Aug 19, 2019

martinhoefling Aug 20, 2019

corneliusweig Aug 19, 2019

corneliusweig Aug 19, 2019

ahmetb Aug 19, 2019

martinhoefling Aug 20, 2019

ahmetb commented Aug 20, 2019 •

edited

Loading

corneliusweig left a comment

corneliusweig commented Aug 26, 2019

k8s-ci-robot commented Aug 26, 2019

ahmetb commented Aug 26, 2019

	shortDescription: Imports secrets from gopass
	shortDescription: Imports Secrets from gopass

Add gopass plugin to krew plugin index #208

Add gopass plugin to krew plugin index #208

Conversation

martinhoefling commented Aug 18, 2019

k8s-ci-robot commented Aug 18, 2019

martinhoefling commented Aug 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahmetb commented Aug 18, 2019

corneliusweig left a comment

Choose a reason for hiding this comment

corneliusweig Aug 19, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corneliusweig Aug 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahmetb commented Aug 20, 2019 • edited Loading

corneliusweig left a comment

Choose a reason for hiding this comment

corneliusweig commented Aug 26, 2019

k8s-ci-robot commented Aug 26, 2019

ahmetb commented Aug 26, 2019

corneliusweig Aug 19, 2019 •

edited

Loading

corneliusweig Aug 20, 2019 •

edited

Loading

ahmetb commented Aug 20, 2019 •

edited

Loading