Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve generate_list.sh to correctly generate offline file/image lists using ansible. #8537

Closed
tmurakam opened this issue Feb 13, 2022 · 0 comments · Fixed by #8538
Closed

Improve generate_list.sh to correctly generate offline file/image lists using ansible. #8537

tmurakam opened this issue Feb 13, 2022 · 0 comments · Fixed by #8538
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tmurakam
Copy link
Contributor

What would you like to be added:

Current contrib/offline/generate_list.sh parses some yaml files and expands variables without using ansible.
This is a bit of tough task, and hard to maintain.

It should make use of jinja2 template and ansible to expand variables.

I'm now working on this improvement.

Why is this needed:

Easy to maintenance, and increase stability of the script.
@tmurakam tmurakam added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2022
tmurakam added a commit to tmurakam/kubespray that referenced this issue Feb 13, 2022
@tmurakam
feat(offline): Improve generate_list.sh to generate offline file list…
a1bfc1f 
… using ansible (kubernetes-sigs#8537)

Use jinja2 template and ansible to expand variables.
@tmurakam tmurakam mentioned this issue Feb 13, 2022
Merged
k8s-ci-robot pushed a commit that referenced this issue Feb 14, 2022
@tmurakam
feat(offline): Improve generate_list.sh to generate offline file list…
b02e682 
… using ansible (#8537) (#8538)

Use jinja2 template and ansible to expand variables.
Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this issue Feb 18, 2022
Merge branch 'master' into feature/virtualbox
6fceccf 
* master:
  Configure Etcd container_manager explicitly (kubernetes-sigs#8521)
  Fix print_hostnames of inventory.py (kubernetes-sigs#8554)
  Fix etcd_events not getting upgraded in upgrade-cluster.yml (kubernetes-sigs#8550)
  nerdctl: upgrade to 0.16.1 (kubernetes-sigs#8539)
  Allow pausing after upgrade but before uncordon (kubernetes-sigs#8530)
  [calico] upgrade release checksums (kubernetes-sigs#8544)
  Allow to specify a source address for metallb peerings, and target only some nodes using node selectors (kubernetes-sigs#8534)
  add support for Dual Stack node InternalIP (kubernetes-sigs#8542)
  terraform/gcp: Allow to change extra disk types (kubernetes-sigs#8524)
  add support for Calico IP6_AUTODETECTION_METHOD (kubernetes-sigs#8541)
  implement download mirrors support (kubernetes-sigs#8474)
  Fix: Error when creating subnets more than AZ (kubernetes-sigs#8516)
  feat(offline): Improve generate_list.sh to generate offline file list using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538)
  docs: Update offline-environment.md for containerd (kubernetes-sigs#8520) (kubernetes-sigs#8523)
  Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode (kubernetes-sigs#8519)
  Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
tmurakam added a commit to tmurakam/kubespray that referenced this issue Mar 5, 2022
@tmurakam
feat(offline): Improve generate_list.sh to generate offline file list…
fb17f8e 
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538)

Use jinja2 template and ansible to expand variables.
@tmurakam tmurakam mentioned this issue Mar 5, 2022
Merged
tmurakam added a commit to tmurakam/kubespray that referenced this issue Mar 5, 2022
@tmurakam
feat(offline): Improve generate_list.sh to generate offline file list…
337b56d 
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538)

Use jinja2 template and ansible to expand variables.
k8s-ci-robot pushed a commit that referenced this issue Mar 7, 2022
@tmurakam
feat(offline): Improve generate_list.sh to generate offline file list…
92d6c2d 
… using ansible (#8537) (#8538) (#8606)

Use jinja2 template and ansible to expand variables.
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this issue Apr 16, 2022
@tmurakam @sakuraiyuta
feat(offline): Improve generate_list.sh to generate offline file list…
9cb031b 
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538)

Use jinja2 template and ansible to expand variables.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this issue Jun 29, 2023
@tmurakam @LuckySB
feat(offline): Improve generate_list.sh to generate offline file list…
8409dd6 
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538)

Use jinja2 template and ansible to expand variables.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this issue Oct 21, 2023
@tmurakam @LuckySB
feat(offline): Improve generate_list.sh to generate offline file list…
14dc2aa 
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538)

Use jinja2 template and ansible to expand variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(offline): Improve generate_list.sh using ansible (#8537) tmurakam/kubespray
1 participant
@tmurakam