Separate gvisor_download_url for runsc and shim #7760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To download necessary files in advance for offline deployment, we can see all file URLs with contrib/offline/generate_list.sh Most URLs are downloadable, but gvisor's one is not because the URL is a part of full URLs for gvisor. To download gvisor's files from the URLs directory, this separates into two URLs for runsc and the shim.
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
floryut
approved these changes
Jun 30, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I was not aware of this behaviour. Maybe we should exercise this script in CI? |
That is a nice point. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Quehenr
added a commit
to Quehenr/unstable-laboratory-infrastructure-kubespray
that referenced
this pull request
Aug 2, 2021
* master: (23 commits) retry to fetch binary if it fails first time (kubernetes-sigs#7839) Update vSphere CPI (kubernetes-sigs#7838) doc: Update 'Kubespray vs Kubeadm' (kubernetes-sigs#7834) Update MetalLB documentation (kubernetes-sigs#7833) Disable OVH CI until voucher situation is cleared up (kubernetes-sigs#7824) Fix how to get image ID on offline deployment (kubernetes-sigs#7808) CRI-O: Install libseccomp2 from backports on Debian 10 (kubernetes-sigs#7816) fix(misc): contrib/terraform/aws (kubernetes-sigs#7818) Separate gvisor_download_url for runsc and shim (kubernetes-sigs#7760) Allow failure on tf-elax_ubuntu18-calico (kubernetes-sigs#7814) Add containerd on Flatcar Container Linux (kubernetes-sigs#7681) Fixup label for oracle linux bootstrap Update multus to 3.7.2 (and move to ghcr.io) Set default k8s version to 1.21.3 Add hashes for k8s 1.20.8/.9 and 1.19.12/.13 and 1.21.3 Fix erroneous ansible args Update kube-router to 1.3.0 Update flannel to 0.14.0 (moved from coreos repo to flannel-io) Use dashboard 2.3.1 image Set Helm default version to 3.6.3 ...
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2021
To download necessary files in advance for offline deployment, we can see all file URLs with contrib/offline/generate_list.sh Most URLs are downloadable, but gvisor's one is not because the URL is a part of full URLs for gvisor. To download gvisor's files from the URLs directory, this separates into two URLs for runsc and the shim.
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
To download necessary files in advance for offline deployment, we can see all file URLs with contrib/offline/generate_list.sh Most URLs are downloadable, but gvisor's one is not because the URL is a part of full URLs for gvisor. To download gvisor's files from the URLs directory, this separates into two URLs for runsc and the shim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
To download necessary files in advance for offline deployment, we can see all file URLs with contrib/offline/generate_list.sh
Most URLs are downloadable, but gvisor's one is not because the URL is a part of full URLs for gvisor.
To download gvisor's files from the URLs directory, this separates into two URLs for runsc and the shim.
Does this PR introduce a user-facing change?: