Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI-O: Install libseccomp2 from backports on Debian 10 #7816

Merged
merged 2 commits into from
Jul 23, 2021
Merged

CRI-O: Install libseccomp2 from backports on Debian 10 #7816

merged 2 commits into from
Jul 23, 2021

Conversation

AnatomicJC
Copy link
Contributor

libseccomp2 is a required dependency of cri-o-runc package

The one provided in Debian 10 repositories is outdated

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I wrote to Podman and CRI-O package maintainer, aka @lsm5 / https://github.com/lsm5 about this issue on Debian 10, and he told me enabling the buster backport was necessary and pointed me to https://podman.io/blogs/2021/03/02/podman-support-for-older-distros.html

Thanks !

Does this PR introduce a user-facing change?:

NONE

@AnatomicJC
CRI-O: Install libseccomp2 from backports on Debian 10
5f7ab61 
libseccomp2 is a required dependency of cri-o-runc package

The one provided in Debian 10 repositories is outdated
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 21, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi July 21, 2021 16:04
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @AnatomicJC. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2021
@lsm5
Copy link

lsm5 commented Jul 21, 2021

@AnatomicJC just to clarify, the note above RE: stopping builds for older distros applies to podman, buildah and skopeo, not necessarily to cri-o. For cri-o, I'll let @haircommander speak as he's the main maintainer for it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 21, 2021
@haircommander
Copy link

yes this is also necessary for cri-o

@oomichi
Copy link
Contributor

oomichi commented Jul 21, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 21, 2021
oomichi
oomichi reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment.

/cc @oomichi

roles/container-engine/cri-o/tasks/crio_repo.yml Outdated
filename: debian-backports
when:
- ansible_distribution == "Debian"
- ansible_distribution_version == "10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line 9-11 seems redundant with line 22-24 in the same block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right @oomichi , I first add this condition on the 2 tasks, then put them in a block, and forgot to remove it.

Fixed, thanks !

@k8s-ci-robot k8s-ci-robot requested a review from oomichi July 23, 2021 06:21
@AnatomicJC
7816: Remove useless when condition
fd7d3e2 
As this condition is handled by block
@oomichi
Copy link
Contributor

oomichi commented Jul 23, 2021

Thanks for updating.
I cannot find anything else.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AnatomicJC, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@AnatomicJC
Copy link
Contributor Author

The vagrant pipeline has failed :/ https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1446750270

@floryut
Copy link
Member

floryut commented Jul 23, 2021 •
edited
Loading

The vagrant pipeline has failed :/ https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1446750270

Retried

@k8s-ci-robot k8s-ci-robot merged commit 627a06e into kubernetes-sigs:master Jul 23, 2021
Quehenr added a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Aug 2, 2021
@Quehenr
Merge branch 'master' into feature/virtualbox
474597b 
* master: (23 commits)
  retry to fetch binary if it fails first time (kubernetes-sigs#7839)
  Update vSphere CPI (kubernetes-sigs#7838)
  doc: Update 'Kubespray vs Kubeadm' (kubernetes-sigs#7834)
  Update MetalLB documentation (kubernetes-sigs#7833)
  Disable OVH CI until  voucher situation is cleared up (kubernetes-sigs#7824)
  Fix how to get image ID on offline deployment (kubernetes-sigs#7808)
  CRI-O: Install libseccomp2 from backports on Debian 10 (kubernetes-sigs#7816)
  fix(misc): contrib/terraform/aws (kubernetes-sigs#7818)
  Separate gvisor_download_url for runsc and shim (kubernetes-sigs#7760)
  Allow failure on tf-elax_ubuntu18-calico (kubernetes-sigs#7814)
  Add containerd on Flatcar Container Linux (kubernetes-sigs#7681)
  Fixup label for oracle linux bootstrap
  Update multus to 3.7.2 (and move to ghcr.io)
  Set default k8s version to 1.21.3
  Add hashes for k8s 1.20.8/.9 and 1.19.12/.13 and 1.21.3
  Fix erroneous ansible args
  Update kube-router to 1.3.0
  Update flannel to 0.14.0 (moved from coreos repo to flannel-io)
  Use dashboard 2.3.1 image
  Set Helm default version to 3.6.3
  ...
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@AnatomicJC @LuckySB
CRI-O: Install libseccomp2 from backports on Debian 10 (kubernetes-si…
caee4f1 
…gs#7816)

* CRI-O: Install libseccomp2 from backports on Debian 10

libseccomp2 is a required dependency of cri-o-runc package

The one provided in Debian 10 repositories is outdated

* 7816: Remove useless when condition

As this condition is handled by block
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@AnatomicJC @sakuraiyuta
CRI-O: Install libseccomp2 from backports on Debian 10 (kubernetes-si…
292af9f 
…gs#7816)

* CRI-O: Install libseccomp2 from backports on Debian 10

libseccomp2 is a required dependency of cri-o-runc package

The one provided in Debian 10 repositories is outdated

* 7816: Remove useless when condition

As this condition is handled by block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AnatomicJC @k8s-ci-robot @lsm5 @haircommander @oomichi @floryut