Preemption within ClusterQueue and cohort #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
alculquicondor
force-pushed
the
preemption
branch
6 times, most recently
from
59bba33 to
7c68bdc
Compare
alculquicondor
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @ahg-g |
ahg-g
reviewed
Jan 22, 2023
tenzen-y
reviewed
Jan 23, 2023
| "sigs.k8s.io/kueue/pkg/workload" | ||
| ) | ||
|
|
||
| const parallelPreemptions = 8 |
There was a problem hiding this comment.
Do you have reasons why this is hardcoded?
There was a problem hiding this comment.
Just simplicity. We can add a configuration option later. But it might just be a general parallelism parameter, like in scheduler.
alculquicondor
force-pushed
the
preemption
branch
3 times, most recently
from
0283b1c to
3aa7054
Compare
3 tasks
ahg-g
reviewed
Jan 28, 2023
| @@ -38,13 +38,16 @@ const ( | |||
| isNegativeErrorMsg string = `must be greater than or equal to 0` | |||
| ) | |||
|
|
|||
| type ClusterQueueWebhook struct{} | |||
| type ClusterQueueWebhook struct { | |||
| scheme *runtime.Scheme | |||
There was a problem hiding this comment.
Left over from another approach I tried. Removed
k8s-ci-robot
added
do-not-merge/hold
alculquicondor
force-pushed
the
preemption
branch
from
1c0f8c6 to
d1384be
Compare
k8s-ci-robot
removed
the
lgtm
|
squashed into 2 commits |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
With validation and defaulting Change-Id: Ifb618c6e0c0bbf7c8b721b30a764c5a62a8bde22
With integration tests
alculquicondor
force-pushed
the
preemption
branch
from
d1384be to
ba9dcdf
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Feb 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Implements https://github.com/kubernetes-sigs/kueue/tree/05da320/keps/83-workload-preemption
Which issue(s) this PR fixes:
Fixes #83
Special notes for your reviewer: