-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for preemption #618
Add documentation for preemption #618
Conversation
Change-Id: I75cb8023e75f22c44c8271be52033c0d41026666
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #576 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding some suggestions.
Workloads from other ClusterQueues in the cohort that are using more than | ||
their nominal quota. Possible values are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workloads from other ClusterQueues in the cohort that are using more than | |
their nominal quota. Possible values are: | |
Workloads from other ClusterQueues that are using more than | |
their nominal quota in the cohort. The possible values are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move "in the cohort"? The ClusterQueues belong to the cohort.
Changed the other part.
- `LowerPriority`: if the pending workload fits within the nominal | ||
quota of its ClusterQueue, only preempt workloads in the cohort that have | ||
lower priority than the pending Workload. | ||
- `Any`: if the pending workload fits within the nominal quota of its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `Any`: if the pending workload fits within the nominal quota of its | |
- `Any`: if the pending Workload fits within the nominal quota of its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
Note that an incoming Workload can preempt Workloads both within the | ||
ClusterQueue and the cohort. Kueue implements heuristics to preempt as few | ||
Workloads as possible, prefering Workloads with these characteristics: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workloads as possible, prefering Workloads with these characteristics: | |
Workloads as possible, prioritizing Workloads with these characteristics: |
If you decide to keep preferring, fix the typo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂 thanks
I kept the word "preferring". I think "prioritizing" can be confusing given that we talk about priority below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label tide/merge-method-squash
Workloads from other ClusterQueues in the cohort that are using more than | ||
their nominal quota. Possible values are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move "in the cohort"? The ClusterQueues belong to the cohort.
Changed the other part.
- `LowerPriority`: if the pending workload fits within the nominal | ||
quota of its ClusterQueue, only preempt workloads in the cohort that have | ||
lower priority than the pending Workload. | ||
- `Any`: if the pending workload fits within the nominal quota of its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
Note that an incoming Workload can preempt Workloads both within the | ||
ClusterQueue and the cohort. Kueue implements heuristics to preempt as few | ||
Workloads as possible, prefering Workloads with these characteristics: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂 thanks
I kept the word "preferring". I think "prioritizing" can be confusing given that we talk about priority below.
/lgtm |
/hold cancel |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Follow up to #514
Which issue(s) this PR fixes:
Fixes #576
Special notes for your reviewer:
I'm using v1beta1 in this PR, but updates to the rest of the documentation will come in a separate PR.