Add hostprocess containerd logger #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
github-actions
bot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
size/XL
knabben
reviewed
Dec 23, 2021
knabben
reviewed
Dec 23, 2021
knabben
reviewed
Dec 30, 2021
knabben
reviewed
Dec 30, 2021
| # Build runtime image | ||
| FROM mcr.microsoft.com/windows/nanoserver:1809 | ||
| WORKDIR / | ||
| COPY --from=build-env /app/out/containerd-logger.exe . |
There was a problem hiding this comment.
Suggested change
| COPY --from=build-env /app/out/containerd-logger.exe . | |
| COPY --from=build-env /app/out/containerd-logger.exe . | |
| COPY --from=build-env eventFlowConfig.json ./ |
There was a problem hiding this comment.
I left coping the eventflowConfig.json out here since it is copied over via config map.
knabben
reviewed
Dec 30, 2021
Co-authored-by: Amim Knabben <[email protected]>
Co-authored-by: Amim Knabben <[email protected]>
This was referenced Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR:
Containerd by default logs to ETW when installed as a service. This provides a way to dynamically capture those logs via a config map configuration. By using https://github.com/Azure/diagnostics-eventflow can also configure other outputs for these files.
Issue Fixed:
Issue #
Requirements
Notes: