Add Containerd hostprocess container #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Amim Knabben <[email protected]>
Co-authored-by: Amim Knabben <[email protected]>
k8s-ci-robot
added
size/XL
github-actions
bot
added
the
tide/merge-method-squash
marosset
reviewed
Jan 7, 2022
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @marosset |
marosset
reviewed
Jan 7, 2022
marosset
reviewed
Jan 7, 2022
marosset
reviewed
Jan 7, 2022
marosset
reviewed
Jan 7, 2022
Co-authored-by: Mark Rossetti <[email protected]>
marosset
reviewed
Jan 7, 2022
|
overall looks good to me |
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR:
Containerd by default logs to ETW when installed as a service. This provides a way to dynamically capture those logs via a config map configuration. By using https://github.com/Azure/diagnostics-eventflow can also configure other outputs for these files.
replaces #197 so we can test ci before merging
Issue Fixed:
Issue #
Requirements
Notes: