Bump OpenTelemetry libs #2686
Merged
Bump OpenTelemetry libs #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
jsafrane
force-pushed
the
bump-otel46
branch
from
0627511 to
2ed1ec6
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
Started vanilla Block pipeline... Build Number: 2398 |
|
|
Started vanilla Block pipeline... Build Number: 2400 |
|
|
Started vanilla Block pipeline... Build Number: 2403 |
|
|
@adikul30, can I please get more details about the failed tests? What failed and how? How can I re-run the failed test by myself? And, do you have any govet or lint tests? Those could be affected by this PR too. |
@jsafrane, I've run tests tagged with 'csi-block-vanilla'. These tests can be found in the
|
|
Started vanilla Block pipeline... Build Number: 2409 |
|
This PR brings >600 changed files in the imported packages, I think that's quite a big code change :-). |
|
rebased |
jsafrane
force-pushed
the
bump-otel46
branch
from
2ed1ec6 to
2f50019
Compare
|
Started vanilla Block pipeline... Build Number: 2412 |
|
|
@adikul30 how shall we proceed here? I can't fix any e2e errors that I don't see. |
|
Started vanilla Block pipeline... Build Number: 2414 |
|
|
Started Vanilla block pre-checkin pipeline... Build Number: 2599 |
|
Yeah, there's really no way for you to access unless I upload the logs at some place after every test run. But I ran an individual test that had failed as part of the entire suite and it passed, @jsafrane, the tests seem to be very flaky right now, likely underlying infra issues. Let me check with the team if that's the case and if we can merge your change since I don't see any change related issues in the test. |
|
Started Vanilla block pre-checkin pipeline... Build Number: 2601 |
|
jsafrane
force-pushed
the
bump-otel46
branch
from
2f50019 to
58168a3
Compare
|
Started Vanilla block pre-checkin pipeline... Build Number: 2603 |
|
|
Started Vanilla block pre-checkin pipeline... Build Number: 2604 |
divyenpatel
reviewed
Dec 20, 2023
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.6.2 |
There was a problem hiding this comment.
why do we need to change version from v0.6.2 to v0.2.5?
Also we are moving back to apiextensions.k8s.io/v1beta1from apiextensions.k8s.io/v1?
There was a problem hiding this comment.
Good catch, I had an old controller-gen. Fixed now.
|
Bump especially go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp and go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46 to fix CVE-2023-47108. The rest of OpenTelemetry lib updates were required by the new otelhttp.
jsafrane
force-pushed
the
bump-otel46
branch
from
58168a3 to
928e750
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
jsafrane
added a commit
to jsafrane/vsphere-csi-driver
that referenced
this pull request
Jan 3, 2024
Bump especially go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp and go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46 to fix CVE-2023-47108. The rest of OpenTelemetry lib updates were required by the new otelhttp.
jsafrane
added a commit
to jsafrane/vsphere-csi-driver
that referenced
this pull request
Jan 4, 2024
Bump especially go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp and go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46 to fix CVE-2023-47108. The rest of OpenTelemetry lib updates were required by the new otelhttp.
jsafrane
added a commit
to jsafrane/vsphere-csi-driver
that referenced
this pull request
Jan 5, 2024
Bump especially go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp and go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46 to fix CVE-2023-47108. The rest of OpenTelemetry lib updates were required by the new otelhttp.
gnufied
pushed a commit
to gnufied/vsphere-csi-driver
that referenced
this pull request
Jan 22, 2024
Bump especially go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp and go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46 to fix CVE-2023-47108. The rest of OpenTelemetry lib updates were required by the new otelhttp.
gnufied
pushed a commit
to gnufied/vsphere-csi-driver
that referenced
this pull request
May 31, 2024
Bump especially go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp and go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46 to fix CVE-2023-47108. The rest of OpenTelemetry lib updates were required by the new otelhttp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump especially
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp and go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46 to fix CVE-2023-47108.
The rest of lib updates were required by the new otelhttp. Please review + test carefully, there are quite large jumps between versions.
Release note: