-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduling framework document updated with permit moved to a scheduling cycle #1560
scheduling framework document updated with permit moved to a scheduling cycle #1560
Conversation
Welcome @mateuszlitwin! |
Hi @mateuszlitwin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mateuszlitwin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I do not know how to update the image with scheduling and binding cycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mateuszlitwin for working on this. LGTM overall. We need to get the picture updated as well.
Can you also update the "IMPLEMENTATION HISTORY" section?
@bsalamat @misterikkit (not quite sure you're still getting notified..) By any chance, are you able to share the original editable image in this framework KEP? https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20180409-scheduling-framework.md |
/ok-to-test |
I think the updated picture should show |
@mateuszlitwin Exactly. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale @mateuszlitwin https://kubernetes.io/docs/concepts/scheduling-eviction/scheduling-framework/ has a picture you can use here to complete this PR. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Wei, can you confirm that one of us shared the doc with you back in Feb or
May?
… |
@misterikkit Yes, I got that from Bobby. Thanks! BTW: the KEP version is still out-of-dated, but the version on docs.k8s.io is updated. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
changes in the PR will be covered in #2054 |
monitoring/OWNERS: update monitoring approvers
Related PR: kubernetes/kubernetes#88199
Related Issue: kubernetes/kubernetes#88179