Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark scheduling framework as implemented #2054

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Mark scheduling framework as implemented #2054

merged 1 commit into from
Oct 3, 2020

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Oct 2, 2020

Since this is already in stable, we will not have a PRR.

/cc @alculquicondor @Huang-Wei

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2020
@ahg-g ahg-g mentioned this pull request Oct 2, 2020
Closed
alculquicondor
alculquicondor reviewed Oct 2, 2020
View reviewed changes
keps/sig-scheduling/624-scheduling-framework/README.md Outdated

#### PreScore

**Notice: `PreScore` is available since v1alpha2, and it's known as `PostFilter` before this version.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the v1alpha2 looks confusing, given that it's not an API. We should say the k8s minor version.

Copy link
Member Author

@ahg-g ahg-g Oct 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the sentence, the public docs clarifies that, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg

keps/sig-scheduling/624-scheduling-framework/kep.yaml Outdated
see-also:
- "/keps/sig-scheduling/1451-multi-scheduling-profiles"
stage: stable
latest-milestone: "v1.18"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@ahg-g ahg-g force-pushed the framework branch 3 times, most recently from dcea73e to 0015c3b Compare October 2, 2020 14:37
@ahg-g
Copy link
Member Author

ahg-g commented Oct 2, 2020

/hold

just in case :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2020
Huang-Wei
Huang-Wei reviewed Oct 2, 2020
View reviewed changes
keps/sig-scheduling/624-scheduling-framework/kep.yaml Outdated
title: Scheduling Framework
kep-number: 895
authors:
- "@Huang-Wei"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original authors should be bsalamat and misterikkit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, copied the format of this file from your kep :)

keps/sig-scheduling/624-scheduling-framework/kep.yaml Outdated
@@ -0,0 +1,31 @@
title: Scheduling Framework
kep-number: 895
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kep-number: 895
kep-number: 624

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

keps/sig-scheduling/624-scheduling-framework/README.md
Comment on lines +146 to +147
the queue and retried. If a binding cycle is aborted, it will trigger the
[Unreserve](#reserve) method in the Reserve plugin.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to this, can we move the tweaks in #1560 into this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

keps/sig-scheduling/624-scheduling-framework/README.md
* Existing 'Predicate' and 'Priority' functions and preemption logic are
converted to plugins.
* No major bug in the implementation of the framework is reported in the past
three months.

# IMPLEMENTATION HISTORY
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this section? At least with 2 bullets indicating when we transform old format design doc to KEP, and the latest changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the history is long and complicated :) not sure those two bullet points will be useful.

keps/sig-scheduling/624-scheduling-framework/README.md
@@ -250,21 +250,31 @@ func (*BlinkingLightScorer) NormalizeScore(state *CycleState, _ *v1.Pod, nodeSco

If either `Score` or `NormalizeScore` returns an error, the scheduling cycle is aborted.

### Reserve
#### Reserve
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's close #1560 as I assume everything in that PR has been covered here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@ahg-g ahg-g mentioned this pull request Oct 2, 2020
Closed
@Huang-Wei
Copy link
Member

@ahg-g LGTM. Pleas squash the commits.

@ahg-g
Copy link
Member Author

ahg-g commented Oct 2, 2020

/sig scheduling

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Oct 3, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit f0665d0 into kubernetes:master Oct 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 3, 2020
@Huang-Wei Huang-Wei mentioned this pull request Oct 5, 2020
Closed
17 tasks
@ahg-g ahg-g mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@alculquicondor alculquicondor alculquicondor left review comments

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@ahg-g @k8s-ci-robot @Huang-Wei @alculquicondor