Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics changes to metrics overhaul #679

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Add more metrics changes to metrics overhaul #679

merged 1 commit into from
Jan 8, 2019

Conversation

danielqsj
Copy link
Contributor

Some PRs are submitted to change apiserver/kubelet/scheduler/proxy metrics to follow the instrumentation guidelines: kubernetes/kubernetes#71300.
So adding those to the metrics overhaul KEP.
@brancz @DirectXMan12 @ehashman @mxinden @piosz @coffeepac @s-urbaniak @metalmatze

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from brancz and piosz January 7, 2019 13:50
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/pm labels Jan 7, 2019
@brancz
Copy link
Member

brancz commented Jan 8, 2019

Awesome! Thanks a ton for taking care of all of these!

@brancz
Copy link
Member

brancz commented Jan 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, danielqsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit a2a01b4 into kubernetes:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz Awaiting requested review from brancz

@piosz piosz Awaiting requested review from piosz

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielqsj @brancz @k8s-ci-robot @justaugustus