Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metrics changes to metrics overhaul #679

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Add more metrics changes to metrics overhaul #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ status: implementable
* [Export less metrics](#export-less-metrics)
* [Prevent apiserver's metrics from accidental registration](#prevent-apiservers-metrics-from-accidental-registration)
* [Prober metrics](#prober-metrics)
* [Kube-scheduler metric changes](#kube-scheduler-metric-changes)
* [Kube-proxy metric changes](#kube-proxy-metric-changes)
* [Kube-apiserver metric changes](#kube-apiserver-metric-changes)
* [Client-go metric changes](#client-go-metric-changes)
* [Workqueue metrics](#workqueue-metrics)
* [Risks and Mitigations](#risks-and-mitigations)
Expand Down Expand Up @@ -91,6 +94,9 @@ Currently, all Kubelet metrics are exposed as summary data types. This means tha

Hence, where possible, we should change summaries to histograms, or provide histograms in addition to summaries like with the API server metrics.

https://github.com/kubernetes/kubernetes/pull/72323
https://github.com/kubernetes/kubernetes/pull/72470

#### Export less metrics

https://github.com/kubernetes/kubernetes/issues/68522
Expand All @@ -103,6 +109,18 @@ https://github.com/kubernetes/kubernetes/pull/63924

Make prober metrics introduced in https://github.com/kubernetes/kubernetes/pull/61369 conform to the [Kubernetes instrumentation guidelines](https://github.com/kubernetes/community/blob/master/contributors/devel/instrumentation.md).

### Kube-scheduler metric changes

https://github.com/kubernetes/kubernetes/pull/72332

### Kube-proxy metric changes

https://github.com/kubernetes/kubernetes/pull/72334

### Kube-apiserver metric changes

https://github.com/kubernetes/kubernetes/pull/72336

### Client-go metric changes

#### Workqueue metrics
Expand Down