Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and remove hack fixed by upstream cookie library #5040

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

BrianKopp
Copy link
Contributor

This PR resolves two follow-up comments on #4949. First, it clarifies documentation as requested in comment. Second, it removes hack that was required since resty-cookie library did not allow SameSite=None - this has been fixed in upstream and merged into base image in #5011.

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @BrianKopp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2020
@aledbf
Copy link
Member

aledbf commented Feb 8, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2020
@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

Merging #5040 into master will increase coverage by 1.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5040     +/-   ##
=========================================
+ Coverage   58.57%   59.97%   +1.4%     
=========================================
  Files          88       88             
  Lines        6843     7168    +325     
=========================================
+ Hits         4008     4299    +291     
- Misses       2398     2413     +15     
- Partials      437      456     +19
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 90.62% <0%> (+2.08%) ⬆️
internal/ingress/controller/template/template.go 82.7% <0%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4278b...7c7a1b9. Read the comment docs.

@BrianKopp
Copy link
Contributor Author

Will do some more extensive manual testing tomorrow before I'm OK putting this as not Draft

@aledbf
Copy link
Member

aledbf commented Feb 10, 2020

@BrianKopp any chance you can change the state of the PR?

This will be the last PR before 0.29. The plan is to release the version Thursday or Friday.

@BrianKopp
Copy link
Contributor Author

Yes, I'll get it tested today to confirm and get it moved. Sorry for the delay!

@BrianKopp BrianKopp marked this pull request as ready for review February 10, 2020 17:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2020
@aledbf
Copy link
Member

aledbf commented Feb 10, 2020

/test all

@aledbf
Copy link
Member

aledbf commented Feb 10, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2020
@aledbf
Copy link
Member

aledbf commented Feb 10, 2020

@BrianKopp thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, BrianKopp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5e54f66 into kubernetes:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants