-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation and remove hack fixed by upstream cookie library #5040
Conversation
Hi @BrianKopp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #5040 +/- ##
=========================================
+ Coverage 58.57% 59.97% +1.4%
=========================================
Files 88 88
Lines 6843 7168 +325
=========================================
+ Hits 4008 4299 +291
- Misses 2398 2413 +15
- Partials 437 456 +19
Continue to review full report at Codecov.
|
Will do some more extensive manual testing tomorrow before I'm OK putting this as not Draft |
@BrianKopp any chance you can change the state of the PR? This will be the last PR before 0.29. The plan is to release the version Thursday or Friday. |
Yes, I'll get it tested today to confirm and get it moved. Sorry for the delay! |
/test all |
/lgtm |
@BrianKopp thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, BrianKopp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR resolves two follow-up comments on #4949. First, it clarifies documentation as requested in comment. Second, it removes hack that was required since resty-cookie library did not allow
SameSite=None
- this has been fixed in upstream and merged into base image in #5011.What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: