support parse key-only environment variable

[ngtuna]

fix #303

[kadel]

👍
But can you please also add unit test for this?

[sebgoa]

yeah, let's blocked everything until we get in the habit of making sure we have unit tests...

[ngtuna]

ok so @kadel I added the unit test. Please take a look.

[coveralls]

Coverage increased (+2.1%) to 37.093% when pulling fdc47a4 on ngtuna:env-key-only into 65e19e3 on kubernetes-incubator:master.

[coveralls]

Coverage increased (+2.1%) to 37.093% when pulling fdc47a4 on ngtuna:env-key-only into 65e19e3 on kubernetes-incubator:master.

[cdrage]

LGTM with the exception of the merge-conflict.

[ngtuna]

Tks @cdrage Rebased!

[coveralls]

Coverage increased (+2.0%) to 37.481% when pulling 8253805 on ngtuna:env-key-only into 7bda857 on kubernetes-incubator:master.

[cdrage]

LGTM 👍

[ngtuna]

@cdrage please approve again then I can merge it.

[cdrage]

@ngtuna I can approve, but since I still don't have access to @kubernetes-incubator it wont appear as 👍 / green.

[surajssd]

why not do it in literal form in here itself than declaring multiple variables? I don't say it's bad/wrong or not, just curious?

[ngtuna]

Well It's just for making test cases looks clearly.

[ngtuna]

@cdrage I see :-(

[surajssd]

@ngtuna Also three more conditions that are not tested:

env: "foo:bar=foobar"     name: "foo" val: "bar=foobar"
env: "foo=foo:bar"        name: "foo" val: "foo:bar"

env: "foo:"               name: "foo" val: ""

otherwise LGTM

[ngtuna]

@surajssd Added and rebased. Please take a look and approve if it's okay for you.

[coveralls]

Coverage increased (+2.6%) to 38.485% when pulling 7556f6f on ngtuna:env-key-only into 072d481 on kubernetes-incubator:master.

[coveralls]

Coverage increased (+2.6%) to 38.485% when pulling 7556f6f on ngtuna:env-key-only into 072d481 on kubernetes-incubator:master.