Switch from godep to glide

[kadel]

fixed #314

I tried to use Glide instead of Godep, setting up was surprisingly easy.
With only one catch: You need to run glide update with --strip-vendor otherwise glide keeps vendor directories inside kompose vendor dir (/vendor/.../vendor/...) In some project this can be useful, but kompose can't be build whit this.
Overall I really like glide.

But (there is always but 😎 )
It looks like glide is not striping unused code from vendored dependencies , like godep does.
with glide vendor is 277M :-(
with godep it was 52M

https://github.com/sgotti/glide-vc might help with that. (haven't tried yet)
Or we can remove vendor from git as @ngtuna suggested here. But I expressed my view there. I think it is better to keep vendor in project repo.

[surajssd]

I am +1 on keeping vendor dir as it is and not removing it from kompose.

[ngtuna]

So with this PR should we delete the PR #297 ?

[ngtuna]

Yes you could run glide-vc --only-code --no-tests. Vendor folder size was only 32MB left after running it. Built success.

[kadel]

So there is a reason why glide doesn't strip dependencies.
It is explained here http://engineeredweb.com/blog/2016/go-why-not-strip-unused-pkgs/
But I don't know if that is valid point or not.

Maybe @sebgoa has opinion on that?

[kadel]

updated this PR with glide-vc cleanup.
vendor is now 32M

[kadel]

I will add some docs to this PR explaining how to add and update dependencies

[ericchiang]

you'll probably want to squash those commits, or git will still track the removed objects.

[kadel]

@ericchiang yes that is the plan, I will definitely squash this before merge.

@ngtuna I'll add short docs and probably scripts that will wrap glide and glide-vc. Than I'll ping you for another review. 😉

[kadel]

I've added docs and scripts that validate if vendor is clean.

It is ready for another review.
ping @ngtuna

[sebgoa]

@technosophos could you advise us with this ?

[coveralls]

Coverage remained the same at 35.01% when pulling a0ba435 on kadel:glide into 862419b on kubernetes-incubator:master.

[technosophos]

/cc @mattfarina (who volunteered to look at this on SIG-Apps).

This looks good to me. If you're checking in vendor, then glide-vc is a great way to manage that. And everything else looks great.

[surajssd]

@technosophos so can we go ahead with merging this?

[technosophos]

I have no reason to object to merging this, though I'm not a core maintainer on this project.

[ngtuna]

@surajssd I think we can let it passed now. @kadel can you merge?

[cdrage]

@ngtuna He's away until after the new year, so you'll have to merge or we could wait until he's back :)

[surajssd]

@technosophos @ngtuna @cdrage thank you merging this in.

[ngtuna]

oh I see. So could you also take a look into #317 @surajssd @cdrage ?