-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias kops replace
to kops apply
to match kubectl
#2616
Comments
I've implemented this suggestion in the linked PR, if anyone could comment on it that would be great. |
So I'm working on "kops server" mode, where we will be able to run kops as a kubernetes apiserver, and you'll be able to use My concern therefore is that we might be increasing the mental overhead, if So I agree this would be good, but I ask that we wait until we have |
If I'm getting that right, you're integrating kops into kubernetes in the
form of additional resource types (InstanceGroup, Cluster), bootstrapped by
running a master on your management machine ("kops server" mode)? Or not
quite?
…On Fri, Jun 9, 2017 at 3:00 PM, Justin Santa Barbara < ***@***.***> wrote:
So I'm working on "kops server" mode, where we will be able to run kops as
a kubernetes apiserver, and you'll be able to use kubectl apply.
My concern therefore is that we might be increasing the mental overhead,
if kops apply is subtly different from kubectl apply. kubectl apply
applies immediately, which is certainly going to be one big different (and
feeds into the --yes discussion happening on other issues).
So I agree this would be good, but I ask that we wait until we have kubectl
apply and can compare, to make sure we aren't painting ourselves into a
corner. (And yes, I know replace already exists as well.. :-) )
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2616 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEePF7VOVpAB2YtSInMCG26s5iauJKc_ks5sCUHcgaJpZM4Nhj8v>
.
|
You're right, but let me provide a bit more of a description! Kubernetes has api-machinery which does object versioning etc. We've used that machinery for a long time in kops - it is why the kops YAML files "look like" k8s objects. Over the past few months the kubernetes project has refactored out the kubernetes api server logic, such that it is now practical to run an apiserver with your own API objects. It would work with kubectl. So we would have a kubernetes apiserver that only spoke Cluster & InstanceGroup etc. That's what I'm calling the "kops server". In 1.7 there should be early support for aggregating API servers, so the kops server would appear in the "main" kubernetes API. So you would be able to edit your instancegroups from the main kubectl. I don't see this replacing the current mode of operation (where there is no server). If nothing else, it makes bootstrapping hard! Also, I like the lightweight CLI / S3 mode of operation. But for teams, it might be handy to have a standalone kops server, rather than sharing an S3 bucket. And some people might prefer it (and we could probably create an AMI that boots up into kops server, to avoid the bootstrapping problem). There are challenges here: the current mode of operation of k8s is quite different from kops in that when you But this is good, and I want to do it, but it's one of those where I'm like "uh oh, this could make other work much harder" so my opinion is that we should wait to see how that other work goes. But that is predicated on this PR being a "nice to have" rather than critical functionality. (And it is nice to have, but I hope this makes sense!) |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
As discussed here.
The idea is to change
kops replace
tokops apply
, so it matcheskubectl
and its semantics (you don't replace a cluster, you apply a new desired state to it, which may or may not involve replacing parts of the cluster or the whole cluster).Practically we'd have to copy the command definition code for the replace command and change
replace
toapply
, and then perhaps add a deprecation warning to thereplace
command, AFAICT that's all there is to it.The text was updated successfully, but these errors were encountered: