-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias replace -> apply and add deprecation notice to replace #2618
Conversation
Hi @WillemMali. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I've previously opened an issue for this (#2616), linking the two with this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments about refactor
Use: "apply -f FILENAME", | ||
Short: apply_short, | ||
Long: apply_long, | ||
Example: apply_example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add an alias here for replace and then remove the replace code. There is no need to have duplicate code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented your suggestion, does my current PR look better to you?
@k8s-bot ok to test |
Thanks for the PR - I'll put some comments on the issue |
I think that the big difference between I agree that apply is better than replace, but they are different in this regard. I think just aliasing them will lead to more confusion. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: WillemMali Assign the PR to them by writing Associated issue: 2603 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@WillemMali PR needs rebase |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
As discussed here.
The idea is to rename the
replace
command toapply
, to closer matchkubectl
and lower mental overhead.I implemented an alias to the
replace
command and marked thereplace
command as deprecated in the CLI help and docs. I don't expect this PR to pass without any discussion, I'm just hoping this PR will speed up and focus the discussion.(It also includes a bit of documentation that was in
master
but had not been generated, I don't quite understand how that got through CI.)This change is![Reviewable](https://camo.githubusercontent.com/bdad2d5a4be7a00dc3b2426ea57eabd73ef84d8ed5ee05653b2f1501b6ea93ab/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)