Import package aliases are not uniform.

[yuxiaobo96]

In kops, there are some import package aliases are not uniform.
For "k8s.io/kops/pkg/apis/kops", there are several aliases:

"k8s.io/kops/pkg/apis/kops"
kops "k8s.io/kops/pkg/apis/kops"
api "k8s.io/kops/pkg/apis/kops"
kopsapi "k8s.io/kops/pkg/apis/kops"

For "k8s.io/apimachinery/pkg/apis/meta/v1", there are several aliases:

v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

Therefore, I suggest to update:
"k8s.io/kops/pkg/apis/kops" -> kopsapi "k8s.io/kops/pkg/apis/kops"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1" -> metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

[yuxiaobo96]

/cc @hakman
/cc @rifelpet
Please give some suggestions.

[tanjunchen]

Good suggestion.why not?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[martin-tomes]

Hi, can I also participate? I am a newbie and this seems to be a task which I could manage. I have already signed the CLA.

I am not sure if I can open the PR and reference it to this issue without asking thats why I am asking here in advance :)

[rifelpet]

I think the open PR #8256 might be addressing the remaining imports mentioned in this issue but if you find other imports with similar inconsistencies feel free to mention them here and open a PR :)

[martin-tomes]

@rifelpet Actually, there are lots of such files:

cmd/kops/create_ig.go
cmd/kops/export_kubecfg.go
cmd/kops/get_cluster.go
cmd/kops/rollingupdatecluster.go
cmd/kops/delete_cluster.go
cmd/kops/upgrade_cluster.go
cmd/kops/validate_cluster.go
upup/pkg/fi/cloudup/loader.go
upup/pkg/fi/cloudup/spec_builder.go
upup/pkg/fi/cloudup/networking.go
pkg/model/components/containerd_test.go
upup/pkg/fi/cloudup/deepvalidate_test.go
upup/pkg/fi/cloudup/populatecluster_test.go
upup/pkg/fi/cloudup/populate_cluster_spec.go
upup/pkg/fi/cloudup/bootstrapchannelbuilder_test.go
upup/pkg/fi/cloudup/populateinstancegroup_test.go

And the above are only api -> kopsapi :) I have corrected all of them and will open the PR and start searching for v1 -> metav1 files.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.