Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticcheck:update import package aliases #8256

Closed
wants to merge 1 commit into from

Conversation

yuxiaobo96
Copy link
Contributor

ref: #8244
update import package aliases:
kops "k8s.io/kops/pkg/apis/kops" -> kopsapi "k8s.io/kops/pkg/apis/kops"
api "k8s.io/kops/pkg/apis/kops" -> kopsapi "k8s.io/kops/pkg/apis/kops"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuxiaobo96
To complete the pull request process, please assign justinsb
You can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuxiaobo96
Copy link
Contributor Author

/cc @rifelpet @hakman

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet January 3, 2020 06:37
@k8s-ci-robot
Copy link
Contributor

@yuxiaobo96: GitHub didn't allow me to request PR reviews from the following users: hakman.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rifelpet @hakman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuxiaobo96
Copy link
Contributor Author

/assign @justinsb

@yuxiaobo96
Copy link
Contributor Author

/assign @rifelpet
Please take a look.

@tanjunchen
Copy link
Member

/lgtm
/cc @rifelpet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2020
@yuxiaobo96
Copy link
Contributor Author

/assign @rifelpet

@k8s-ci-robot
Copy link
Contributor

@yuxiaobo96: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2020
@rifelpet
Copy link
Member

If you rebase this we can get this approved and merged. sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants