Spotinst: Bump controller image

[liranp]

This PR bumps the Spotinst cluster controller to version 1.0.18.

[k8s-ci-robot]

Hi @liranp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mikesplain]

/ok-to-test

[mikesplain]

Hi @liranp, thanks so much for the bump! Can you also adjust the version here so kops picks up your changes? Thanks!

kops/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go

Line 450 in 0f26f2b

version := "1.0.16"

[justinsb]

When we update this, we also need to update this: https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go#L450

(I hope we're going to make all this much better with bundles real-soon-now, but for now that's what we need...)

Also, I recommend making the version in bootstrap channel builder 1.0.18-kops.1, because in the past we've had a problem where we wanted to update the manifest, but the image itself didn't change versions. The kops.1 suffix lets you do that, but otherwise there's nothing we can do...

[justinsb]

Thanks @liranp - would be great if you could update bootstrapchannelbuilder at the same time, to ensure the updates get applied to existing clusters (and I'm thinking about exactly how to use bundles right now to make this better).

Also, does this need to be cherry-picked to 1.11?

[liranp]

@mikesplain, @justinsb: Thank you! Sorry for missing this file. I've updated it as well. Regarding your question, it'd be great to see it in version 1.11.0, but if this is a problem we can wait.

[mikesplain]

Thanks for the patch fix @liranp! We can add -kops.1 in the future when needed so I'll merge this in.
Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liranp, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mikesplain]

I'll also open a cherry pick up for you

[liranp]

@mikesplain Perfect, thank you!