Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Bump controller image #6129

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Spotinst: Bump controller image #6129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b3c8c
feat: bump controller version to 1.0.18
liranp Nov 29, 2018
a471938
fix: update bootstrapchannelbuilder
liranp Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...esources/addons/spotinst-kubernetes-cluster-controller.addons.k8s.io/v1.8.0.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ spec:
spec:
containers:
- name: spotinst-kubernetes-cluster-controller
image: spotinst/kubernetes-cluster-controller:1.0.16
image: spotinst/kubernetes-cluster-controller:1.0.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we update this, we also need to update this: https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go#L450

(I hope we're going to make all this much better with bundles real-soon-now, but for now that's what we need...)

Also, I recommend making the version in bootstrap channel builder 1.0.18-kops.1, because in the past we've had a problem where we wanted to update the manifest, but the image itself didn't change versions. The kops.1 suffix lets you do that, but otherwise there's nothing we can do...

imagePullPolicy: Always
env:
- name: SPOTINST_TOKEN
Expand Down
2 changes: 1 addition & 1 deletion ...esources/addons/spotinst-kubernetes-cluster-controller.addons.k8s.io/v1.9.0.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ spec:
spec:
containers:
- name: spotinst-kubernetes-cluster-controller
image: spotinst/kubernetes-cluster-controller:1.0.16
image: spotinst/kubernetes-cluster-controller:1.0.18
imagePullPolicy: Always
env:
- name: SPOTINST_TOKEN
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/cloudup/bootstrapchannelbuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ func (b *BootstrapChannelBuilder) buildManifest() (*channelsapi.Addons, map[stri

if featureflag.Spotinst.Enabled() {
key := "spotinst-kubernetes-cluster-controller.addons.k8s.io"
version := "1.0.16"
version := "1.0.18"

{
id := "v1.8.0"
Expand Down