Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Audit Webhook config #6361

Merged
merged 11 commits into from
Mar 15, 2019
Merged

Conversation

mbelangerupgrade
Copy link
Contributor

please consider this pr to fix the missing apiserver configuration

related issue: #5803

Thanks

@k8s-ci-robot
Copy link
Contributor

Hi @mbelangerupgrade. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 18, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2019
@mbelangerupgrade
Copy link
Contributor Author

i signed it

@jpbelangerupgrade
Copy link
Contributor

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 21, 2019
@jpbelangerupgrade
Copy link
Contributor

It's weird.. we did run make gofmt and no changes were needed by the go format... Any ideas why the build says we need to format?

@mikesplain
Copy link
Contributor

@jpbelangerupgrade @mbelangerupgrade Unfortunately this is because go fmt is different for golang 1.10 which we need to support until kops/k8s 1.13. See here: #6145

If you're using homebrew, you can easily install 1.10 by doing something like brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/2f76690921dc2a5f89686448917b762982dc201f/Formula/go.rb

@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2019
@jpbelangerupgrade
Copy link
Contributor

Thanks @mikesplain for the link. Fixed the gofmt issues, looks like the build passed! nice!

Let us know if there's anything else missing.

@mbelangerupgrade
Copy link
Contributor Author

Should be ready for review/test. Can someone have a look?

@mbelangerupgrade
Copy link
Contributor Author

Another friendly ping, can anyone take review of this PR

@justinsb justinsb added this to the 1.12 milestone Mar 14, 2019
@justinsb
Copy link
Member

Sorry for delay - it got caught up in the test account failure followed by the docker cve :-(

Thanks for the contribution @mbelangerupgrade

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mbelangerupgrade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit b25ff1c into kubernetes:master Mar 15, 2019
justinsb added a commit to justinsb/kops that referenced this pull request Mar 15, 2019
This is going to be in componentconfig soon, so it would be nice to
have the same types.

These flags were recently mapped in kubernetes#6361 and have not yet been in a
release - it's now or never!  (Though technically it is only the
AuditWebhookBatchThrottleEnable that won't parse identically)

Also added tests!
justinsb added a commit to justinsb/kops that referenced this pull request Mar 15, 2019
This is going to be in componentconfig soon, so it would be nice to
have the same types.

These flags were recently mapped in kubernetes#6361 and have not yet been in a
release - it's now or never!  (Though technically it is only the
AuditWebhookBatchThrottleEnable that won't parse identically)

Also added tests!
justinsb added a commit to justinsb/kops that referenced this pull request Mar 18, 2019
This is going to be in componentconfig soon, so it would be nice to
have the same types.

These flags were recently mapped in kubernetes#6361 and have not yet been in a
release - it's now or never!  (Though technically it is only the
AuditWebhookBatchThrottleEnable that won't parse identically)

Also added tests!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants