-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Audit Webhook config #6361
Conversation
Hi @mbelangerupgrade. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
i signed it |
I signed it |
It's weird.. we did run |
@jpbelangerupgrade @mbelangerupgrade Unfortunately this is because go fmt is different for golang 1.10 which we need to support until kops/k8s 1.13. See here: #6145 If you're using homebrew, you can easily install 1.10 by doing something like |
/ok-to-test |
Ran gofmt with golang 1.10.3
Missing one file that's not in make gofmt
Thanks @mikesplain for the link. Fixed the gofmt issues, looks like the build passed! nice! Let us know if there's anything else missing. |
Should be ready for review/test. Can someone have a look? |
Another friendly ping, can anyone take review of this PR |
Sorry for delay - it got caught up in the test account failure followed by the docker cve :-( Thanks for the contribution @mbelangerupgrade /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mbelangerupgrade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is going to be in componentconfig soon, so it would be nice to have the same types. These flags were recently mapped in kubernetes#6361 and have not yet been in a release - it's now or never! (Though technically it is only the AuditWebhookBatchThrottleEnable that won't parse identically) Also added tests!
This is going to be in componentconfig soon, so it would be nice to have the same types. These flags were recently mapped in kubernetes#6361 and have not yet been in a release - it's now or never! (Though technically it is only the AuditWebhookBatchThrottleEnable that won't parse identically) Also added tests!
This is going to be in componentconfig soon, so it would be nice to have the same types. These flags were recently mapped in kubernetes#6361 and have not yet been in a release - it's now or never! (Though technically it is only the AuditWebhookBatchThrottleEnable that won't parse identically) Also added tests!
please consider this pr to fix the missing apiserver configuration
related issue: #5803
Thanks