Sync data-types for webhook config with upstream #6626
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
cc @mbelangerupgrade - I added tests and noticed that we could use the "native" types. It doesn't make a lot of difference (better validation maybe), except for the boolean flag, where I think people expect to type |
|
Marking as blocks-next because this is merge-or-close; once we release 1.12.0-alpha.1 we shouldn't change the API types. |
justinsb
force-pushed
the
more_flag_tests_apiserver
branch
from
30281e4 to
8d13fb2
Compare
This is going to be in componentconfig soon, so it would be nice to have the same types. These flags were recently mapped in kubernetes#6361 and have not yet been in a release - it's now or never! (Though technically it is only the AuditWebhookBatchThrottleEnable that won't parse identically) Also added tests!
justinsb
force-pushed
the
more_flag_tests_apiserver
branch
from
8d13fb2 to
720174c
Compare
There was a problem hiding this comment.
Thanks @justinsb agreed, we should get this in!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is going to be in componentconfig soon, so it would be nice to
have the same types.
These flags were recently mapped in #6361 and have not yet been in a
release - it's now or never! (Though technically it is only the
AuditWebhookBatchThrottleEnable that won't parse identically)
Also added tests!