Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: New instance group type: Ocean #7040

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

liranp
Copy link
Contributor

@liranp liranp commented May 20, 2019

This PR adds a new instance group type, Spotinst Ocean, which abstracts the provisioning, auto scaling, and management of Kubernetes nodes.

To maintain backward compatibility we continue to create all instance groups as Spotinst Elastigroups. Spotinst Ocean support can be enabled by toggling a new feature flag on:

export KOPS_FEATURE_FLAGS="+Spotinst,SpotinstOcean"

When Spotinst Ocean's feature flag is toggled on all Node instance groups will be created as a single Spotinst Ocean cluster (nodes.<cluster-name>) with multiple LaunchSpecs (one for each instance group).

NOTE: We released this version to our customers as a custom build. This version has been tested and used by Spotinst's customers in many production environments since version 1.11.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @liranp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 20, 2019
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2019
@liranp liranp force-pushed the feature-spotinst-ocean branch 3 times, most recently from 7678347 to 5c8fb73 Compare May 23, 2019 12:55
@liranp liranp force-pushed the feature-spotinst-ocean branch 4 times, most recently from 959a025 to 6446ee9 Compare June 3, 2019 09:36
@liranp liranp force-pushed the feature-spotinst-ocean branch from 6446ee9 to 8002005 Compare June 3, 2019 09:38
@chrisz100
Copy link
Contributor

As it’s all feature gated
/lgtm

@mikesplain leaving the approval to you ;-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2019
@justinsb
Copy link
Member

Yes, approving as it is feature-gated - thanks @liranp!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, liranp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
k8s-ci-robot added a commit that referenced this pull request Jun 20, 2019
Spotinst: New instance group type: Ocean
@k8s-ci-robot k8s-ci-robot merged commit a8e7109 into kubernetes:master Jun 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8002005 into kubernetes:master Jun 20, 2019
@liranp liranp deleted the feature-spotinst-ocean branch January 22, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants