-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotinst: New instance group type: Ocean #7040
Spotinst: New instance group type: Ocean #7040
Conversation
Hi @liranp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
7678347
to
5c8fb73
Compare
959a025
to
6446ee9
Compare
6446ee9
to
8002005
Compare
As it’s all feature gated @mikesplain leaving the approval to you ;-) |
Yes, approving as it is feature-gated - thanks @liranp! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, liranp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Spotinst: New instance group type: Ocean
This PR adds a new instance group type, Spotinst Ocean, which abstracts the provisioning, auto scaling, and management of Kubernetes nodes.
To maintain backward compatibility we continue to create all instance groups as Spotinst Elastigroups. Spotinst Ocean support can be enabled by toggling a new feature flag on:
When Spotinst Ocean's feature flag is toggled on all
Node
instance groups will be created as a single Spotinst Ocean cluster (nodes.<cluster-name>
) with multiple LaunchSpecs (one for each instance group).