-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotinst: Add OWNERS file to Spotinst specific packages #8533
Conversation
Hi @liranp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @liranp thanks for taking this initiative! It looks like you'll need to join the kubernetes org before you can be added to OWNERS files. Links are above /ok-to-test |
@rifelpet Thanks! I've just noticed that one of the requirements is to be sponsored by two existing reviewers. Is it okay to mention you guys as my sponsors? |
yes, I'll be happy to sponsor you! |
Thank you so much, @rifelpet! @justinsb, @chrisz100 Is it okay to mention one of you as well? |
@liranp I’m happy to sponsor you, mention me and we can get this process started. |
Thank you so much, @mikesplain! |
I've opened an issue against the kubernetes/org repo (kubernetes/org#1634). |
/verify-owners |
1 similar comment
/verify-owners |
Thanks for taking this on! We look forward to your future contributions! /retest |
/approve welcome! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, liranp, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We propose that we add OWNERS file to Spotinst specific packages in order to decrease the time of development lifecycle (for example, please see the following PRs: #7040, #7252 and #8294), so we can review and approve things ourselves. For now, these files contain only one approver (me), but we will add more contributors later.