some resources upgraded to google provider 3.0

[mccare]

Upgraded some google cloud terraform resources to fit google cloud provider 3.0

• instance template name_prefix is maximum length of 32
• instance group manager needs the instance_template in a version block

See also https://www.terraform.io/docs/providers/google/guides/version_3_upgrade.html

Btw, syntax is still terraform 0.11 and needs to be transformed with terraform 0.12upgrade

[k8s-ci-robot]

Hi @mccare. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rifelpet]

/ok-to-test

These changes appear backwards compatible with the 2.X provider version, so it appears to be safe though I don't use GCE + terraform so I can't test it myself.

Travis CI is complaining that you need to run make goimports

[mccare]

Did run make gofmt

[rifelpet]

One more thing, it might be a good idea to add a version requirement to the provider definition so that users dont accidentally use 2.X.

It should just be a matter of adding a providerGoogle["version"] = ">= 3.0.0" here:

kops/upup/pkg/fi/cloudup/terraform/target.go

Lines 192 to 199 in ddc0879

	if t.Cloud.ProviderID() == kops.CloudProviderGCE {
	providerGoogle := make(map[string]interface{})
	providerGoogle["project"] = t.Project
	providerGoogle["region"] = t.Region
	for k, v := range tfGetProviderExtraConfig(t.clusterSpecTarget) {
	providerGoogle[k] = v
	}
	providersByName["google"] = providerGoogle

https://www.terraform.io/docs/configuration/providers.html#provider-configuration

[justinsb]

Thanks @mccare

As we're trying to get GCE support to stable, this seems like the right time to make these changes - thanks! cc @geojaz

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mccare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justinsb]

And @rifelpet is right, sorry I overlooked that comment. I'll send a PR to implement it!