-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform GCE output: specify minimum GCE provider version #8106
Conversation
There were some incompatible changes made in version 3 of the GCE provider, so we specify a minimum version to make version mismatches more obvious. As suggested in kubernetes#8103
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@justinsb: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is incompatible with terraform 0.11 it seems. For terraform 0.11 you need to put the version into the provider block. |
Agreed. I spoke with a hashicorp dev about this and they mentioned that long-term they are moving towards |
this is no longer needed so im going to close it out |
@rifelpet: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@justinsb: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There were some incompatible changes made in version 3 of the GCE
provider, so we specify a minimum version to make version mismatches
more obvious.
As suggested in #8103