Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Performance tests: negative UDP latency values for some test runs. #1818

Closed
VivekThrivikraman-est opened this issue May 31, 2021 · 16 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@VivekThrivikraman-est
Copy link

What happened:
UDP latency metrics collected while running network performance test cases (clusterloader2/testing/network) intermittently contains negative values.

What you expected to happen:
UDP latency should be always positive.

How to reproduce it (as minimally and precisely as possible):
Issue is not seen when running locally in Kind or local vm cluster. Negative values are seen when the testcases are run in k8s CI/CD(GCE).

Anything else we need to know?:
It is confirmed from the logs that Iperf2 tool which is used for collecting the metrics return these -ve values. Raised this in iperf2 forum :
https://sourceforge.net/p/iperf2/discussion/general/thread/a1bcdb67d8/

They suspect this to be clock synchronization issue(they mentioned NTP synchronized nodes also can have latency).

Aggregated metrics output for UDP attached:
NetworkPerformanceMetrics_N_M_UDP_P2P_network_performance_udp-50_50_2021-05-21T08_39_04Z.json.txt

Environment:
Testcases are run as part of prow job in k8s CI/CD, in GCE.

@VivekThrivikraman-est VivekThrivikraman-est added the kind/bug Categorizes issue or PR as related to a bug. label May 31, 2021
@aojea
Copy link
Member

aojea commented May 31, 2021

We've been talking about this in slack, and since the VM synchronisation seems complex problem to fix , we though that the best solution moving forward will be to gather more data to get better insights, maybe we only need the trend and not the absolute values.

The doubt that we have is if it would be good to operate only with positive numbers, i.e. truncate negative values to 0

@wojtek-t what do you think?

@wojtek-t
Copy link
Member

We do clock-synchronization in GCE - I personally doubt it's clock difference. I bet it's a real bug...

@VivekThrivikraman-est
Copy link
Author

@wojtek-t is it NTP ?

@hanamantagoudvk
Copy link

@wojtek-t @aojea : What do you think of considering negative values as zero. ? Shall we proceed with that idea ?

@mm4tt
Copy link
Contributor

mm4tt commented Jun 11, 2021

@mm4tt
Copy link
Contributor

mm4tt commented Jun 11, 2021

If we're seeing negative values in order of microseconds then, IMHO, it's 99% clock synchronization / precision issue.

Have we seen a negative value strictly greater than microseconds? We can wait for perf-dash to contain the network-performance dashboards to confirm.

If the answer is not then the question is whether we care about this level of precision. My intuition is that we don't and it's not worth fixing. Changing the measurement to treat negative values as zero is probably the preferred course of action.

@VivekThrivikraman-est
Copy link
Author

Thanks @mm4tt , as you mentioned we will first fix perfdash and monitor to make sure latency is always in microseconds and then make a decision.

@aojea
Copy link
Member

aojea commented Jun 17, 2021

Thanks @mm4tt , as you mentioned we will first fix perfdash and monitor to make sure latency is always in microseconds and then make a decision.

http://perf-dash.k8s.io/#/?jobname=network-performance&metriccategoryname=Network_Baseline&metricname=UDP_P2P&Metric=Latency

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2021
@wojtek-t
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2021
@wojtek-t
Copy link
Member

wojtek-t commented Jan 3, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 3, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants