Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding additional metric for UDP Protocol #1843

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Adding additional metric for UDP Protocol #1843

merged 1 commit into from
Jul 5, 2021

Conversation

hanamantagoudvk
Copy link

a) Loss of packet in percentage added
b) Percentile calculation corrected

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @hanamantagoudvk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from krzysied and mm4tt June 24, 2021 17:05
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2021
@hanamantagoudvk hanamantagoudvk force-pushed the tcp-udp-tuning branch 2 times, most recently from abbdf85 to 300946a Compare June 25, 2021 10:39
@hanamantagoudvk
Copy link
Author

/assign @mm4tt @wojtek-t

@hanamantagoudvk
Copy link
Author

@wojtek-t @mm4tt : could you please review this PR ?

@hanamantagoudvk
Copy link
Author

/assign @marseel

marseel
marseel reviewed Jul 2, 2021
View reviewed changes
clusterloader2/pkg/measurement/common/network/network_performance_measurement.go
// Sometimes iperf gives negative values for latency. As short-term fix
// we are considering them as zero.
if metricIndex == udpLatencyAverage && metricResponse[metricIndex] < 0 {
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that later on you are computing percentile based on aggregatePodPairMetrics array. Here you are skipping adding results for udpLatencyAverage if latency is lower than zero. If you want to assume that negative latency is zero as short term fix, don't you want to append this zero to array for percentile computation?
Could you clarify maybe what negative latency means (I can imagine that adding zero/not adding zero to array might depend on it).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marseel , you can fine more context to this PR in the issue we raised #1818

Adding additional metric for UDP Protocol
dac7002 
a) Loss of packet in percentage added
b) Percentile calculation corrected
@marseel
Copy link
Member

marseel commented Jul 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanamantagoudvk, marseel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@marseel
Copy link
Member

marseel commented Jul 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 833b630 into kubernetes:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marseel marseel marseel left review comments

@krzysied krzysied Awaiting requested review from krzysied

@mm4tt mm4tt Awaiting requested review from mm4tt

Assignees

@marseel marseel

@mm4tt mm4tt

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanamantagoudvk @k8s-ci-robot @marseel @mm4tt @wojtek-t