Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prow: dogs win the fighting #9135

Closed
xiangpengzhao opened this issue Aug 23, 2018 · 24 comments
Closed

prow: dogs win the fighting #9135

xiangpengzhao opened this issue Aug 23, 2018 · 24 comments
Assignees
@ixdy
Labels
kind/🐶 All puppers are good puppers. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@xiangpengzhao
Copy link
Contributor

When I call my cat, I can't find it. (kubernetes/kubernetes#62582 (comment))

When I call my dog, it appears. (kubernetes/kubernetes#62582 (comment))

Anyway, interesting plugins!

/cc @fejta
@xiangpengzhao
Copy link
Contributor Author

/meow

@k8s-ci-robot
Copy link
Contributor

@xiangpengzhao: http://thecatapi.com appears to be down

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiangpengzhao
Copy link
Contributor Author

/woof

@k8s-ci-robot
Copy link
Contributor

@xiangpengzhao: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link
Contributor

/woof

@k8s-ci-robot
Copy link
Contributor

@stevekuznetsov: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov stevekuznetsov added the kind/🐶 All puppers are good puppers. label Aug 23, 2018
@spiffxp
Copy link
Member

spiffxp commented Aug 23, 2018

noooooo 🐱

@ixdy
Copy link
Member

ixdy commented Aug 23, 2018

/meow

@k8s-ci-robot
Copy link
Contributor

@ixdy: http://thecatapi.com appears to be down

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy
Copy link
Member

ixdy commented Aug 23, 2018

This is a new version as of August 2018 - now with added JSON support!

Maybe related?

@cjwagner cjwagner added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Aug 23, 2018
@nikhita
Copy link
Member

nikhita commented Aug 23, 2018

https://twitter.com/adenforshaw/status/1031485169448808448

@spiffxp spiffxp mentioned this issue Aug 24, 2018
Merged
@ixdy
Copy link
Member

ixdy commented Aug 24, 2018

it looks like the cat api no longer returns a source_url, but we don't use that, so it's fine.

working on a fix now.
/assign

@ixdy
Copy link
Member

ixdy commented Aug 24, 2018

actually, it seems like the API is completely different, and it no longer even has categories. :(

this is more involved, punting to someone else.
/unassign

@bobcatfish
Copy link
Contributor

actually, it seems like the API is completely different, and it no longer even has categories. :(

😭

@ixdy ixdy closed this as completed Aug 24, 2018
@ixdy ixdy reopened this Aug 24, 2018
@ixdy
Copy link
Member

ixdy commented Aug 24, 2018

why is that button even there
/woof woof

@ixdy
Copy link
Member

ixdy commented Aug 24, 2018

/assign

ok I have a fix after all

@ixdy ixdy mentioned this issue Aug 24, 2018
Merged
@ixdy
Copy link
Member

ixdy commented Aug 24, 2018

/meow

@k8s-ci-robot
Copy link
Contributor

@ixdy: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy
Copy link
Member

ixdy commented Aug 24, 2018

(this was fixed upstream as well)

@ixdy
Copy link
Member

ixdy commented Aug 24, 2018

/meow space

@k8s-ci-robot
Copy link
Contributor

@ixdy: cat image

In response to this:

/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy
Copy link
Member

ixdy commented Aug 24, 2018

/meow boxes

@k8s-ci-robot
Copy link
Contributor

@ixdy: cat image

In response to this:

/meow boxes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy ixdy mentioned this issue Aug 24, 2018
Merged
@xiangpengzhao
Copy link
Contributor Author

Thanks @ixdy for helping the cats be back! Guess they will be fighting with dogs again :) I like the plugins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixdy ixdy

Labels
kind/🐶 All puppers are good puppers. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@spiffxp @bobcatfish @cjwagner @stevekuznetsov @ixdy @xiangpengzhao @nikhita @k8s-ci-robot