Update cat plugin to use new JSON cat api #9153
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
|
I've tested this with |
|
Thank god 😭 |
|
/woof |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
prow/plugins/cat/cat_test.go
Outdated
| @@ -39,10 +38,7 @@ var human = flag.Bool("human", false, "Enable to run additional manual tests") | |||
| var category = flag.String("category", "", "Request a particular category if set") | |||
prow/plugins/cat/cat_test.go
Outdated
| @@ -354,17 +308,9 @@ func TestCats(t *testing.T) { | |||
| state: "open", | |||
| action: github.GenericCommentActionCreated, | |||
| body: "/meow clothes", | |||
| shouldComment: true, | |||
| shouldComment: false, | |||
There was a problem hiding this comment.
Given that this is a regression in ux a better response here would be to treat this as equivalent to /meow and leave a comment teaching the person that categories are no longer supported.
Then after a few months switch to this behavior.
There was a problem hiding this comment.
cat now chomps if you request a category
|
thanks! |
|
/assign @fejta |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
apparently categories, source URL, voting, etc are still supported, just the docs are wrong. not sure we should deploy this after all. |
|
Maybe keep the switch to the json api? (but without the change in category behavior) |
The Cat API was recently updated with a completely new and seemingly incompatible API.
The browse/vote interface no longer exists, so
source_urlwas removed from the response. It also seems that CATegories are no longer supported. I've removed this functionality from the cat plugin.On the plus side, it now supports json, which is moderately nicer than XML.
Fixes #9135.