Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one of the link in /docs/concepts/scheduling-eviction/assign-pod-node.md is outdated #39864

Closed
ziyi-xie opened this issue Mar 9, 2023 · 5 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@ziyi-xie
Copy link
Contributor

ziyi-xie commented Mar 9, 2023

This is a Feature Request

What would you like to be added

Updated link in the Assigning Pods to Nodes page (The Note part, sorry you may need to scroll down a bit.)

Why is this needed
About the heading ID here, the Assigning Pods to Nodes page (The Note part, sorry you may need to scroll down a bit.) is still using #scheduled-by-default-scheduler , but #scheduled-by-default-scheduler part in DeamonSet page has been deleted.
I'm thinking about changing the heading ID to #how-daemon-pods-are-scheduled and could I ask if you think this modification is appropriate or not?

Comments

/language en

@ziyi-xie ziyi-xie added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ziyi-xie ziyi-xie changed the title [en] one of the link in /docs/concepts/scheduling-eviction/assign-pod-node.md is outdated one of the link in /docs/concepts/scheduling-eviction/assign-pod-node.md is outdated Mar 9, 2023
@sftim
Copy link
Contributor

sftim commented Mar 9, 2023

/kind bug
/remove-kind feature

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Mar 9, 2023
Dhairya-Arora01 added a commit to Dhairya-Arora01/website that referenced this issue Mar 12, 2023
@Dhairya-Arora01
Copy link
Contributor

/assign

@Shubham82
Copy link
Contributor

Closing this issue, as it was resolved in the following PR: #39936
/close

@k8s-ci-robot
Copy link
Contributor

@Shubham82: Closing this issue.

In response to this:

Closing this issue, as it was resolved in the following PR: #39936
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

5 participants