Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja]Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md #38800

Merged
merged 14 commits into from
Mar 16, 2023

Conversation

ziyi-xie
Copy link
Contributor

@ziyi-xie ziyi-xie commented Jan 6, 2023

There are several updates in the original English text and therefore this page is outdated.
This PR updated Japanese translation for the /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md file.

Fixes #38756

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from bells17 January 6, 2023 09:22
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kakts January 6, 2023 09:22
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2023
@ziyi-xie ziyi-xie changed the title Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-no… [ja] Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md Jan 6, 2023
@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Jan 6, 2023

/retitle [WIP][ja]Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md

@k8s-ci-robot k8s-ci-robot changed the title [ja] Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md [WIP][ja]Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2023
@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Jan 6, 2023

/assign @nasa9084
/cc @atoato88 @t-inu
Hi! I've updated Japanese translation for the /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md file line 1 to line 157 (That would be line 1 to line 112 in the Japanese version), would you mind checking if everything looks alright at your convenience time please? Here is the original English text and thank you so much!

@netlify
Copy link

netlify bot commented Jan 6, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7ea13b6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640e6113525f5e00085a6d26
😎 Deploy Preview https://deploy-preview-38800--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 6, 2023
@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Jan 6, 2023

/remove-language en

@k8s-ci-robot k8s-ci-robot removed the language/en Issues or PRs related to English language label Jan 6, 2023
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still in the middle of my review, but I left comments.

@atoato88
Copy link
Contributor

The target page on preview site for this PR:

@ziyi-xie
Copy link
Contributor Author

The target page on preview site for this PR:

Thank you so much for the link!

Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed content till the ### Nodeの分離/制限 section.

@t-inu
Copy link
Member

t-inu commented Feb 6, 2023

@ziyi-xie
The file pod-with-node-affinity.yaml has already been updated in PR #39247.
You no longer need to update this file.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2023
@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Feb 7, 2023

I've updated Japanese translation for the /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md file line 158 to line 329 (That would be line 113 to line 221 in the Japanese version), would you mind checking if everything looks alright at your convenience time please? Here is the original English text and thank you so much!

@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Feb 7, 2023

@ziyi-xie The file pod-with-node-affinity.yaml has already been updated in PR #39247. You no longer need to update this file.

Thank you so much for the information! I'll modify it as soon as possible.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2023
@ziyi-xie
Copy link
Contributor Author

@t-inu @atoato88 Hi! I've updated Japanese translation for the /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md file till the end, would you mind checking if everything looks alright at your convenience time please? Here is the original English text and thank you so much!

@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Mar 7, 2023

It's about heading IDs. The original heading ID used in here is deleted, so it won't jump to the right place in the original English text. I changed the ID here in Japanese page, and I'm wondering if it's necessary or not.

I think we can do followings:

  • Merge this PR use #scheduled-by-default-scheduler similar with original content.

  • Create a issue about "dead heading ID in en content", and update that by other PRs.

    • I think en content is basically truth even if that have some errors. that's why I wrote this step.
  • We can feedback that to ja content by other PR.

It will take some time, but it will keep the valid of content.

Thank you so much for the kind instructions!
I've changed the ID in Japanese page back to #scheduled-by-default-scheduler and will create an issue with en label to check whether it's appropriate or not.

@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Mar 9, 2023

It's about heading IDs. The original heading ID used in here is deleted, so it won't jump to the right place in the original English text. I changed the ID here in Japanese page, and I'm wondering if it's necessary or not.

I think we can do followings:

  • Merge this PR use #scheduled-by-default-scheduler similar with original content.

  • Create a issue about "dead heading ID in en content", and update that by other PRs.

    • I think en content is basically truth even if that have some errors. that's why I wrote this step.
  • We can feedback that to ja content by other PR.

It will take some time, but it will keep the valid of content.

Thank you so much for the kind instructions! I've changed the ID in Japanese page back to #scheduled-by-default-scheduler and will create an issue with en label to check whether it's appropriate or not.

FYI: #39864

@atoato88
Copy link
Contributor

atoato88 commented Mar 10, 2023

/lgtm

And the topic about "#scheduled-by-default-scheduler" related to: #39484

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b5167214f6e4ae3b844833d6f9ef5c598cc779e1

@atoato88
Copy link
Contributor

/assign @nasa9084
Could you review this?

@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Mar 10, 2023

/lgtm

And the topic about "#scheduled-by-default-scheduler" related to: #39484

Sorry I just noticed the assign-pods-nodes.md file in #39484 may not be the same file as mine.
@atoato88 @nasa9084 I'm planning to add all the heading IDs in this file ASAP, sorry for the inconvenience and could you review afterwards?

@ziyi-xie
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Mar 10, 2023

/lgtm
And the topic about "#scheduled-by-default-scheduler" related to: #39484

Sorry I just noticed the assign-pods-nodes.md file in #39484 may not be the same file as mine. @atoato88 @nasa9084 I'm planning to add all the heading IDs in this file ASAP, sorry for the inconvenience and could you review afterwards?

I just added all the heading IDs and could you review at your spare time please? Thanks in advance!
6e33512

@ziyi-xie
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2023
@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 525eb269b313f54f4c3a40098990e983cf680193

Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1d1743a into kubernetes:main Mar 16, 2023
@ziyi-xie ziyi-xie deleted the update-assign-pod-node branch March 16, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md is outdated
5 participants