-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja]Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md #38800
[ja]Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md #38800
Conversation
/retitle [WIP][ja]Update /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md |
/assign @nasa9084 |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
/remove-language en |
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still in the middle of my review, but I left comments.
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
The target page on preview site for this PR: |
Thank you so much for the link! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed content till the ### Nodeの分離/制限
section.
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
I've updated Japanese translation for the /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md file line 158 to line 329 (That would be line 113 to line 221 in the Japanese version), would you mind checking if everything looks alright at your convenience time please? Here is the original English text and thank you so much! |
@t-inu @atoato88 Hi! I've updated Japanese translation for the /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md file till the end, would you mind checking if everything looks alright at your convenience time please? Here is the original English text and thank you so much! |
Co-authored-by: Toshiaki Inukai <[email protected]>
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Outdated
Show resolved
Hide resolved
Thank you so much for the kind instructions! |
Co-authored-by: Toshiaki Inukai <[email protected]>
FYI: #39864 |
/lgtm And the topic about "#scheduled-by-default-scheduler" related to: #39484 |
LGTM label has been added. Git tree hash: b5167214f6e4ae3b844833d6f9ef5c598cc779e1
|
/assign @nasa9084 |
Sorry I just noticed the assign-pods-nodes.md file in #39484 may not be the same file as mine. |
/hold |
I just added all the heading IDs and could you review at your spare time please? Thanks in advance! |
/unhold |
/lgtm |
LGTM label has been added. Git tree hash: 525eb269b313f54f4c3a40098990e983cf680193
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nasa9084 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There are several updates in the original English text and therefore this page is outdated.
This PR updated Japanese translation for the /content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md file.
Fixes #38756