Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the home page into reusable and translatable blocks #10071

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Make the home page into reusable and translatable blocks #10071

merged 2 commits into from
Sep 14, 2018

Conversation

bep
Copy link
Contributor

@bep bep commented Aug 24, 2018

This commit adds a set of block type shortcodes that is then used to build the home page.

  • These shortcodes gets common image resources from a new headless bundle. These resources can be inherited or overridden by translations.
  • The hardcoded case studies section on the home page is replaced with a query and a loop.
  • The hardcoded feature list on the home page is replaed qith a query and a loop.

NOTE: This PR depends on or replaces #9971, depending how you look on it.

/cc @zacharysarah

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 24, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1479a4e

https://deploy-preview-10071--kubernetes-io-master-staging.netlify.com

@bep bep force-pushed the lang-refactor-home branch 2 times, most recently from e7b26fe to 9d74ec6 Compare August 24, 2018 08:19
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 24, 2018
@Bradamant3
Copy link
Contributor

Bradamant3 commented Aug 24, 2018 •
edited
Loading

/cc @chenopis per earlier conversations about redoing the home page

leaving this comment as is, but oh bot you are so silly ;)

@k8s-ci-robot k8s-ci-robot requested a review from chenopis August 24, 2018 13:23
@k8s-ci-robot
Copy link
Contributor

@Bradamant3: GitHub didn't allow me to request PR reviews from the following users: per, earlier, conversations, the, page.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @chenopis per earlier conversations about redoing the home page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bep bep force-pushed the lang-refactor-home branch from 9d74ec6 to 316cdce Compare August 24, 2018 18:01
@bep bep mentioned this pull request Sep 3, 2018
Closed
@bep bep force-pushed the lang-refactor-home branch from 316cdce to 5108545 Compare September 3, 2018 07:34
@bep
Copy link
Contributor Author

bep commented Sep 3, 2018

I have:

@zacharysarah note that the work I'm doing has a defined order.

@bep
Copy link
Contributor Author

bep commented Sep 7, 2018

@zacharysarah and @chenopis I understand that you are busy, but this is just a reminder in case you have forgotten: This is a prerequisite for further work in this area.

@zacharysarah
Copy link
Contributor

@bep Thanks for the ping and for your patience. I'll review this in the morning (US time) first thing.

zacharysarah
zacharysarah suggested changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bep There are several questions in the review comments. The parts I understand look good! 😅

content/en/_index.html Outdated
<h2>The Challenges of Migrating 150+ Microservices to Kubernetes</h2>
{{< blocks/section id="oceanNodes" >}}
{{% blocks/feature image="flower" %}}
### [Kubernetes]({{< relref "/docs/concepts/overview/what-is-kubernetes" >}}) is a is an open-source system for automating deployment, scaling, and management of containerized applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR introduces a spelling error that isn't present in the original:

[Kubernetes]({{< relref "/docs/concepts/overview/what-is-kubernetes" >}}) is a is an

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

content/en/case-studies/_index.html Outdated
@@ -1,5 +1,6 @@
---
title: Case Studies
linkTitle: View all case studies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title and linkTitle should match:

linkTitle: Case Studies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

bep added 2 commits September 14, 2018 09:02
@bep
Make navigation and UI strings i18n friendly
7aea36e 
This commit

* Extracts most UI strings into i18n bundles so they can be translated
* Makes a proper Hugo menu out of the hardcoded menu that is shown on smaller screens
* Changes the language selector logic to navigate to the current page in the other language if possible (e.g. the translation). If not possible, it takes you to the home page for that language.

For testing, this commit also adds Norwegian as a new language. This is turned off.
@bep
Make the home page into reusable and translatable blocks
1479a4e 
This commit adds a set of block type shortcodes that is then used to build the home page.

* These shortcodes gets common image resources from a new headless bundle. These resources can be inherited or overridden by translations.
* The hardcoded case studies section on the home page is replaced with a query and a loop.
* The hardcoded feature list on the home page is replaed qith a query and a loop.
@bep bep force-pushed the lang-refactor-home branch from 64eb9d7 to 1479a4e Compare September 14, 2018 07:05
@bep
Copy link
Contributor Author

bep commented Sep 14, 2018

@zacharysarah I have just rebased and resolved the new conflicts with master. Also note, if that was not clear already, that your questions/notes above have been addressed.

@zacharysarah
Copy link
Contributor

@bep Thanks for the updates and responses.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1b5ff98 into kubernetes:master Sep 14, 2018
@chenopis chenopis mentioned this pull request Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah approved these changes

@chenopis chenopis Awaiting requested review from chenopis

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bep @k8sio-netlify-preview-bot @Bradamant3 @k8s-ci-robot @zacharysarah