Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secondary nav to use Home #10800

Merged

Conversation

chenopis
Copy link
Contributor

@chenopis chenopis commented Oct 31, 2018

Fix regression caused by #10071. Rename secondary horizontal nav link to "Home" instead of "Documentation".

We want the nav to look like this:
screen shot 2018-10-31 at 2 42 51 pm

Preview: https://deploy-preview-10800--kubernetes-io-master-staging.netlify.com/docs/home/

@chenopis chenopis requested a review from bep October 31, 2018 21:42
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 31, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 96f8705

https://deploy-preview-10800--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Nov 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@Bradamant3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6cd8128 into kubernetes:master Nov 1, 2018
@chenopis chenopis deleted the website/chenopis-docs-home-link branch November 1, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants