Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federation Cleanup (3) doc: clean up the federation and kubefed(federation v1 cli) references. #19583

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Federation Cleanup (3) doc: clean up the federation and kubefed(federation v1 cli) references. #19583

merged 1 commit into from
Mar 31, 2020

Conversation

Colstuwjx
Copy link
Contributor

@Colstuwjx Colstuwjx commented Mar 10, 2020 •
edited
Loading

This PR is the third PR and maybe the last PR for issue #19206 , the previous two are: #19581 , #19572 . After #19581 , #19525 and this PR being merged, all federation v1 content should be cleared (I think) .

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 10, 2020
@Colstuwjx Colstuwjx mentioned this pull request Mar 10, 2020
Closed
9 tasks
@Colstuwjx
Copy link
Contributor Author

TBH, I'm not familiar with the reference generation job, I have been checked the https://kubernetes.io/docs/reference/ page, and didn't see any federation content, it may already have been cleaned up?

I'd like to hold this PR until someone could help me confirm about this, do we need to do something more, or just merge this PR is enough for federation reference clean-up.

/hold
/cc @zacharysarah @kbhawkey @sftim .

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@netlify
Copy link

netlify bot commented Mar 10, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3febfb1

https://deploy-preview-19583--kubernetes-io-master-staging.netlify.com

@jimangel
Copy link
Member

@Colstuwjx I don't have the issue / PR handy, but a few releases back, the scripted generation for fed v1 broke and that was part of the consensus to eliminate the fed v1 material. That explains why it hasn't been generated too.

Is there anything else that was of concern?

@Colstuwjx
Copy link
Contributor Author

@jimangel Thank you for the explanation. Nothing else.
I think it's ready to merge.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020
@Colstuwjx Colstuwjx mentioned this pull request Mar 19, 2020
Merged
@Colstuwjx Colstuwjx mentioned this pull request Mar 30, 2020
Closed
@Colstuwjx
Copy link
Contributor Author

Ping @jimangel @zacharysarah @kbhawkey @sftim , This is the last PR for federation cleanup, and I think it's ready to merge.

Let me know if there are some changes I need to make.
Thanks.

@kbhawkey
Copy link
Contributor

@Colstuwjx , The changes look good.

Page previews:

Is this page relevant to the federation changes:
https://deploy-preview-19583--kubernetes-io-master-staging.netlify.com/docs/concepts/cluster-administration/federation/

https://deploy-preview-19583--kubernetes-io-master-staging.netlify.com/docs/concepts/cluster-administration/cluster-administration-overview/

https://deploy-preview-19583--kubernetes-io-master-staging.netlify.com/docs/reference/tools/

https://deploy-preview-19583--kubernetes-io-master-staging.netlify.com/docs/tasks/debug-application-cluster/debug-cluster/

@Colstuwjx
Copy link
Contributor Author

@kbhawkey Yes, it also cleaned the redirect rules.

@tengqm
Copy link
Contributor

tengqm commented Mar 31, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2020
@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit dc2f94f into kubernetes:master Mar 31, 2020
@Colstuwjx Colstuwjx deleted the clean-up-federation-references branch April 1, 2020 02:05
fancc pushed a commit to fancc/website that referenced this pull request Apr 26, 2020
@Colstuwjx @fancc
doc: clean up the federation and kubefed(federation v1 cli) reference…
767a7b3 
…s. (kubernetes#19583)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidopp davidopp Awaiting requested review from davidopp

@steveperry-53 steveperry-53 Awaiting requested review from steveperry-53

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Colstuwjx @jimangel @kbhawkey @tengqm @k8s-ci-robot