Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead link to kubefed tool #19935

Closed
wants to merge 1 commit into from
Closed

Remove dead link to kubefed tool #19935

wants to merge 1 commit into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 29, 2020

Closes: #19876

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tengqm
You can assign the PR to them by writing /assign @tengqm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 29, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 29, 2020
@netlify
Copy link

netlify bot commented Mar 29, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 093a3b4

https://deploy-preview-19935--kubernetes-io-master-staging.netlify.com

rajeshdeshpande02
rajeshdeshpande02 approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@rajeshdeshpande02 rajeshdeshpande02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind cleanup
/lgtm

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 29, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2020
@viniciusbds viniciusbds mentioned this pull request Mar 29, 2020
Merged
@Colstuwjx
Copy link
Contributor

PR #19583 has already carried this change, and should be the last (I think) PR for federation cleanup.

@tengqm
Copy link
Contributor Author

tengqm commented Mar 31, 2020

/close
Dup of #19583

@tengqm tengqm closed this Mar 31, 2020
@tengqm tengqm deleted the fix-19876 branch July 4, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeshdeshpande02 rajeshdeshpande02 rajeshdeshpande02 approved these changes

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@rajeshdeshpande02 rajeshdeshpande02

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/reference/tools/
4 participants
@tengqm @k8s-ci-robot @Colstuwjx @rajeshdeshpande02