Update minikube documentation #19756

cwansart · 2020-03-20T17:53:20Z

This pull request updates the outdated Minikube documentation using the deprecated --vm-driver parameter, which was replaced by --driver. It also updates the driver lists in all localizations and removing xhyve which does not exist anymore.

k8s-ci-robot · 2020-03-20T17:53:27Z

Welcome @cwansart!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-03-20T17:53:34Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

netlify · 2020-03-20T18:02:20Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 23f955b

https://deploy-preview-19756--kubernetes-io-master-staging.netlify.com

sftim · 2020-03-20T21:34:25Z

Hi @cwansart and thanks for this PR.
To make reviewing easier, we'd like you to limit reviews to a single language.

This is partly because we probably don't have reviewers who speak all of the languages that you want to change, and mostly because we need a signoff from each language team that a PR touches before we can merge it. (The robot that decides on approval can't tell a code-only change from a change that affects the localized text).

Also, different localization teams use different branching strategies - see https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use

Would you be willing to save the non-English changes for the future and revise this to just change the en localization?

cwansart · 2020-03-20T21:45:29Z

Hey @sftim sure, I can do that.

This reverts commit c08906d

This reverts commit c6c14b6

This reverts commit 164729d

cwansart · 2020-03-20T22:00:22Z

Done. The others will follow. I first need to check for their way of handling pull requests.

gochist · 2020-03-20T23:59:01Z

/remove-language de
/remove-language es
/remove-language fr
/remove-language ja
/remove-language ko
/remove-language ru
/remove-language vi
/remove-language zh

sftim

/approve
Needs a technical LGTM (I haven't checked this is accurate)

sftim · 2020-03-21T12:37:50Z

content/en/docs/setup/learning-environment/minikube.md

 ```
 Minikube supports the following drivers:
 {{< note >}}
- See [DRIVERS](https://git.k8s.io/minikube/docs/drivers.md) for details on supported drivers and how to install
+ See [DRIVERS](https://minikube.sigs.k8s.io/docs/reference/drivers/) for details on supported drivers and how to install


Suggested change

See [DRIVERS](https://minikube.sigs.k8s.io/docs/reference/drivers/) for details on supported drivers and how to install

See [Drivers](https://minikube.sigs.k8s.io/docs/reference/drivers/) for details on supported drivers and how to install

spurin · 2020-03-23T18:09:33Z

Non-member feedback:

/lgtm

The minikube start --driver approach worked as per the advice, in my case I tested with docker

james@ubuntu-throwaway-2:~$ minikube start --driver=docker
* minikube v1.8.2 on Ubuntu 18.04
* Using the docker driver based on user configuration
* Downloading preloaded images tarball for k8s v1.17.3 ...
    > preloaded-images-k8s-v1-v1.17.3-docker-overlay2.tar.lz4: 499.26 MiB / 499
* Creating Kubernetes in docker container with (CPUs=2) (2 available), Memory=1993MB (1993MB available) ...
* Preparing Kubernetes v1.17.3 on Docker 19.03.2 ...
  - kubeadm.pod-network-cidr=10.244.0.0/16
* Launching Kubernetes ...
* Enabling addons: default-storageclass, storage-provisioner
* Waiting for cluster to come online ...
* Done! kubectl is now configured to use "minikube"

All of the updated links, resolve accordingly and take you to the expected target references.

On a mac, I can confirm that the step for checking VMX, worked as expected

$ sysctl -a | grep -E --color 'machdep.cpu.features|VMX'
machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH DS ACPI MMX FXSR SSE SSE2 SS HTT TM PBE SSE3 PCLMULQDQ DTES64 MON DSCPL VMX EST TM2 SSSE3 FMA CX16 TPR PDCM SSE4.1 SSE4.2 x2APIC MOVBE POPCNT AES PCID XSAVE OSXSAVE SEGLIM64 TSCTMR AVX1.0 RDRAND F16C

The guidance for using --driver=none also worked as expected -

james@ubuntu-throwaway-2:~$ sudo minikube start --driver=none
* minikube v1.8.2 on Ubuntu 18.04
* Using the none driver based on user configuration
* Running on localhost (CPUs=2, Memory=1993MB, Disk=63340MB) ...
* OS release is Ubuntu 18.04.2 LTS
* Preparing Kubernetes v1.17.3 on Docker 19.03.4 ...
  - kubelet.resolv-conf=/run/systemd/resolve/resolv.conf
    > kubectl.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
    > kubeadm.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
    > kubelet.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
    > kubeadm: 37.52 MiB / 37.52 MiB [---------------] 100.00% 18.59 MiB p/s 2s
    > kubectl: 41.48 MiB / 41.48 MiB [---------------] 100.00% 16.30 MiB p/s 3s
    > kubelet: 106.42 MiB / 106.42 MiB [-------------] 100.00% 26.08 MiB p/s 4s
* Launching Kubernetes ...
* Enabling addons: default-storageclass, storage-provisioner
* Configuring local host environment ...
*
! The 'none' driver provides limited isolation and may reduce system security and reliability.
! For more information, see:
  - https://minikube.sigs.k8s.io/docs/reference/drivers/none/
*
! kubectl and minikube configuration will be stored in /home/james
! To use kubectl or minikube commands as your own user, you may need to relocate them. For example, to overwrite your own settings, run:
*
  - sudo mv /home/james/.kube /home/james/.minikube $HOME
  - sudo chown -R $USER $HOME/.kube $HOME/.minikube
*
* This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true
* Waiting for cluster to come online ...
* Done! kubectl is now configured to use "minikube"

Hope this helps the review process.

k8s-ci-robot · 2020-03-23T18:09:48Z

@spurin: changing LGTM is restricted to collaborators

In response to this:

Non-member feedback:

/lgtm

The minikube start --driver approach worked as per the advice, in my case I tested with docker

james@ubuntu-throwaway-2:~$ minikube start --driver=docker
* minikube v1.8.2 on Ubuntu 18.04
* Using the docker driver based on user configuration
* Downloading preloaded images tarball for k8s v1.17.3 ...
   > preloaded-images-k8s-v1-v1.17.3-docker-overlay2.tar.lz4: 499.26 MiB / 499
* Creating Kubernetes in docker container with (CPUs=2) (2 available), Memory=1993MB (1993MB available) ...
* Preparing Kubernetes v1.17.3 on Docker 19.03.2 ...
 - kubeadm.pod-network-cidr=10.244.0.0/16
* Launching Kubernetes ...
* Enabling addons: default-storageclass, storage-provisioner
* Waiting for cluster to come online ...
* Done! kubectl is now configured to use "minikube"

All of the updated links, resolve accordingly and take you to the expected target references.

On a mac, I can confirm that the step for checking VMX, worked as expected

$ sysctl -a | grep -E --color 'machdep.cpu.features|VMX'
machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH DS ACPI MMX FXSR SSE SSE2 SS HTT TM PBE SSE3 PCLMULQDQ DTES64 MON DSCPL VMX EST TM2 SSSE3 FMA CX16 TPR PDCM SSE4.1 SSE4.2 x2APIC MOVBE POPCNT AES PCID XSAVE OSXSAVE SEGLIM64 TSCTMR AVX1.0 RDRAND F16C

The guidance for using --driver=none also worked as expected -

james@ubuntu-throwaway-2:~$ sudo minikube start --driver=none
* minikube v1.8.2 on Ubuntu 18.04
* Using the none driver based on user configuration
* Running on localhost (CPUs=2, Memory=1993MB, Disk=63340MB) ...
* OS release is Ubuntu 18.04.2 LTS
* Preparing Kubernetes v1.17.3 on Docker 19.03.4 ...
 - kubelet.resolv-conf=/run/systemd/resolve/resolv.conf
   > kubectl.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
   > kubeadm.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
   > kubelet.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
   > kubeadm: 37.52 MiB / 37.52 MiB [---------------] 100.00% 18.59 MiB p/s 2s
   > kubectl: 41.48 MiB / 41.48 MiB [---------------] 100.00% 16.30 MiB p/s 3s
   > kubelet: 106.42 MiB / 106.42 MiB [-------------] 100.00% 26.08 MiB p/s 4s
* Launching Kubernetes ...
* Enabling addons: default-storageclass, storage-provisioner
* Configuring local host environment ...
*
! The 'none' driver provides limited isolation and may reduce system security and reliability.
! For more information, see:
 - https://minikube.sigs.k8s.io/docs/reference/drivers/none/
*
! kubectl and minikube configuration will be stored in /home/james
! To use kubectl or minikube commands as your own user, you may need to relocate them. For example, to overwrite your own settings, run:
*
 - sudo mv /home/james/.kube /home/james/.minikube $HOME
 - sudo chown -R $USER $HOME/.kube $HOME/.minikube
*
* This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true
* Waiting for cluster to come online ...
* Done! kubectl is now configured to use "minikube"

Hope this helps the review process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spurin · 2020-03-23T19:16:04Z

/approve
Needs a technical LGTM (I haven't checked this is accurate)

@sftim please see my recent comment, hopefully this assists on the technical review aspect.

sftim · 2020-03-24T16:44:54Z

/hold
pending v1.18 Kubernetes release

tengqm · 2020-03-26T04:40:55Z

/hold cancel
/lgtm
/approve

k8s-ci-robot · 2020-03-26T04:41:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [sftim,tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Update vm-driver param and driver links * Fix mistakes * Fix spaces * Revert "Fix spaces" This reverts commit c08906d * Revert "Fix mistakes" This reverts commit c6c14b6 * Revert "Update vm-driver param and driver links" This reverts commit 164729d * Update vm-driver param and driver links

Christian Wansart added 2 commits March 20, 2020 18:15

Update vm-driver param and driver links

164729d

Fix mistakes

c6c14b6

k8s-ci-robot requested review from aaron-prindle and alexbrand March 20, 2020 17:54

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 20, 2020

Fix spaces

c08906d

Christian Wansart added 4 commits March 20, 2020 22:55

Revert "Fix spaces"

afe9d9a

This reverts commit c08906d

Revert "Fix mistakes"

c5c4495

This reverts commit c6c14b6

Revert "Update vm-driver param and driver links"

d9f2e2c

This reverts commit 164729d

Update vm-driver param and driver links

23f955b

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2020

sftim reviewed Mar 21, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020

sftim mentioned this pull request Mar 24, 2020

Freeze kubernetes/website to support easy 1.18 Kubernetes release #19809

Closed

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020

k8s-ci-robot assigned tengqm Mar 26, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020

k8s-ci-robot merged commit fca1d58 into kubernetes:master Mar 26, 2020

spurin mentioned this pull request Jul 1, 2020

REQUEST: New membership for spurin kubernetes/org#1975

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update minikube documentation #19756

Update minikube documentation #19756

cwansart commented Mar 20, 2020 •

edited

Loading

k8s-ci-robot commented Mar 20, 2020

k8s-ci-robot commented Mar 20, 2020

netlify bot commented Mar 20, 2020 •

edited

Loading

sftim commented Mar 20, 2020

cwansart commented Mar 20, 2020

cwansart commented Mar 20, 2020

gochist commented Mar 20, 2020

sftim left a comment

sftim Mar 21, 2020

spurin commented Mar 23, 2020

k8s-ci-robot commented Mar 23, 2020

spurin commented Mar 23, 2020

sftim commented Mar 24, 2020

tengqm commented Mar 26, 2020

k8s-ci-robot commented Mar 26, 2020

	See [DRIVERS](https://minikube.sigs.k8s.io/docs/reference/drivers/) for details on supported drivers and how to install
	See [Drivers](https://minikube.sigs.k8s.io/docs/reference/drivers/) for details on supported drivers and how to install

Update minikube documentation #19756

Update minikube documentation #19756

Conversation

cwansart commented Mar 20, 2020 • edited Loading

k8s-ci-robot commented Mar 20, 2020

k8s-ci-robot commented Mar 20, 2020

netlify bot commented Mar 20, 2020 • edited Loading

sftim commented Mar 20, 2020

cwansart commented Mar 20, 2020

cwansart commented Mar 20, 2020

gochist commented Mar 20, 2020

sftim left a comment

Choose a reason for hiding this comment

sftim Mar 21, 2020

Choose a reason for hiding this comment

spurin commented Mar 23, 2020

k8s-ci-robot commented Mar 23, 2020

spurin commented Mar 23, 2020

sftim commented Mar 24, 2020

tengqm commented Mar 26, 2020

k8s-ci-robot commented Mar 26, 2020

cwansart commented Mar 20, 2020 •

edited

Loading

netlify bot commented Mar 20, 2020 •

edited

Loading