Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content/en/case-studies: remove OWNERS #22475

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jul 11, 2020

For kubernetes/org#2013

As a part of cleaning up inactive members (who haven't been active since
the release of v1.11) from OWNERS, this commit removes the OWNERS file
for content/en/case-studies.

Original commit message below.


As a part of cleaning up inactive members (who haven't been active since
the release of v1.11) from OWNERS, this commit removes sarahkconway from
the content/en/case-studies/OWNERS file.

Note: With this change, we are only left with one approver for this
directory. We should look at adding more approvers, but this commit
addresses the problem for the short term by ensuring that the bot
doesn't suggest inactive members for approval.

/assign @alexcontini @zacharysarah
cc @mrbobbytables @SarahKConway

@k8s-ci-robot
Copy link
Contributor

@nikhita: GitHub didn't allow me to assign the following users: alexcontini.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

For kubernetes/org#2013

As a part of cleaning up inactive members (who haven't been active since
the release of v1.11) from OWNERS, this commit removes sarahkconway from
the content/en/case-studies/OWNERS file.

Note: With this change, we are only left with one approver for this
directory. We should look at adding more approvers, but this commit
addresses the problem for the short term by ensuring that the bot
doesn't suggest inactive members for approval.

/assign @alexcontini @zacharysarah
cc @mrbobbytables @SarahKConway

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2020
@nikhita
Copy link
Member Author

nikhita commented Jul 11, 2020

/hold

@nikhita: GitHub didn't allow me to assign the following users: alexcontini.

This is concerning because @alexcontini won't be able to lgtm/approve PRs either if they are not a member of the @kubernetes org.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2020
@netlify
Copy link

netlify bot commented Jul 11, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f3699fc

https://deploy-preview-22475--kubernetes-io-master-staging.netlify.app

@zacharysarah
Copy link
Contributor

@nikhita 👋 Coukd you please delete the entire OWNERS file here? Thank you! 🙇

As a part of cleaning up inactive members (who haven't been active since
the release of v1.11) from OWNERS, this commit removes the OWNERS file
for content/en/case-studies.
@nikhita nikhita force-pushed the cleanup-onwers-case-studies branch from a779a38 to f3699fc Compare July 12, 2020 03:10
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2020
@nikhita
Copy link
Member Author

nikhita commented Jul 12, 2020

Done ✔️

@nikhita nikhita changed the title content/en/case-studies: cleanup inactive members from OWNERS content/en/case-studies: remove OWNERS Jul 12, 2020
@nikhita
Copy link
Member Author

nikhita commented Jul 12, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2020
@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 503e150 into kubernetes:master Jul 12, 2020
@nikhita nikhita deleted the cleanup-onwers-case-studies branch July 12, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants